429938 - no cancelation message is send to attendees if event is deleted

Status: VERIFIED FIXED

(Calendar :: E-mail based Scheduling (iTIP/iMIP), defect)

Description

[juergen.edner]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.14) Gecko/20080404 Firefox/2.0.0.14
Build Identifier: Thunderbird v2.0.0.12 (20080213) / Lightning v0.9pre (2008041918)

An event has been created which includes attendees and the parameter "Send attendees invitations via email" has been checked. When this event is being deleted no cancelation message is send to the attendees.

Reproducible: Always

Steps to Reproduce:
1. create and event, add attendees, check "Send attendees invitations via email" box.
2. save event
3. delete the event
Actual Results:  
the event is being deleted without sending a cancelation message.

Expected Results:  
a dialog should appear when the event is being deleted which asks if a cancelation message should me send or not, like OL2K3 is doing it.

Comment 1

[Hubert FONGARNAND]

Attachment: Implement event canceling

Implement event canceling when deleting the whole event or deleting an attendee

please review!

Comment 2

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 318396 [details] [diff] [review]
Implement event canceling



It would be great if the attendee-calculation part this part of the code could be revised a bit. A lot of nested loops are used (i.e .some() will internally loop through itemAtt) My idea would be to use a js object to create a map of attendees on the original item,

for each (var att in originalItemAtt) {
  attMap[att.id] = att;
}

for each (var att in itemAtt) {
  if (att.id in attMap) {
    // Attendee was in original item.
    delete attMap[att.id]
  } else {
    // Attendee was not in original item
    addedAttendees.push(att);Arrays
  }
}

// Now attMap should contain all original attendees, that are not in the new item. These can be canceled.
// addedAttendes contains those that were not in the original item but are in the new item. These can be invited

Does this make sense? Please tell me if this doesn't improve performance.

>+    } else
>+    {
>+        recipients = aRecipientsList;
} else {

>+    switch (aTypeOfInvitation) {
>+        case 'request':
>+            item.setProperty("METHOD", "REQUEST");
>+            break;
>+        case 'cancel':
>+            item.setProperty("METHOD", "CANCEL");
>+            break;
>+    }
I think the value of the aTypeOfInvitation parameter should be uppercase, then you could directly set the method here.


>+imipBarCancelText=This message contains a canceling to an event.
This message contains an event cancellation.

>+itipCancelBody=%1$S has cancelled this event : « %2$S »
in en-US, its canceled, in en-GB its cancelled. Please correct to en-US. I'd remove the space before the : also.


r- for now, but only to get a new patch with comments fixed and the map-thing considered.

Comment 3

[Hubert FONGARNAND]

Attachment: Implement event canceling v2

Comment 4

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 319568 [details] [diff] [review]
Implement event canceling  v2

Looks good, I'll add a couple of extra brackets for one-line if() statements according to our style guide before checkin

r=philipp

Comment 5

[Philipp Kewisch [:Fallen][☁️📆]]

Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED

Comment 6

[Hubert FONGARNAND]

There's still a bug with this implementation. If there's only one attendee, delete this attendee and no cancel message is sent... 

Comment 7

[Hubert FONGARNAND]

Attachment: [checked in] Fix last bug...

Comment 8

[Daniel Boelzle [:dbo]]

Comment on attachment 321595 [details] [diff] [review]
[checked in] Fix last bug...

looks good, r=dbo

Checked in on HEAD and MOZILLA_1_8_BRANCH.

What's IMO is yet a bit odd is if you remove some attendees and add some others, you get asked twice if you want to notify the attendees.

Comment 9

[Daniel Boelzle [:dbo]]

Hubert, set this bug to FIXED if everything's fixed.

Comment 10

[Hubert FONGARNAND]

It seem's to be ok!

Comment 11

[Andreas Treumann]

Checked in lightning build 2008072919 -> VERIFIED