Closed Bug 430071 Opened 17 years ago Closed 17 years ago

Don't allow exceptions out of AddSearchProviderHandler

Categories

(Camino Graveyard :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Camino2.0

People

(Reporter: stuart.morgan+bugzilla, Assigned: stuart.morgan+bugzilla)

Details

(Keywords: fixed1.8.1.15)

Attachments

(2 files)

Bug 430058 would have been much less bad if I had remembered an important rule about writing ObjC code in a Gecko callback: catch all exceptions.
Flags: camino1.6.1+
Attached patch fixSplinter Review
I left one line outside; it's extremely unlikely that we could get an exception from that call, and the source URL would be extremely helpful in debugging any future issue if someone finds the log message in their console after the fact.
Attachment #316822 - Flags: superreview?(mikepinkerton)
Attachment #316822 - Flags: superreview?(mikepinkerton) → superreview+
Landed on trunk and MOZILLA_1_8_BRANCH.
Status: NEW → RESOLVED
Closed: 17 years ago
Keywords: fixed1.8.1.15
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: