Closed
Bug 430164
Opened 17 years ago
Closed 17 years ago
Add error code to Keychain failure logs
Categories
(Camino Graveyard :: OS Integration, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Camino2.0
People
(Reporter: stuart.morgan+bugzilla, Assigned: stuart.morgan+bugzilla)
Details
(Keywords: fixed1.8.1.15)
Attachments
(1 file)
|
11.01 KB,
patch
|
Jeff.Dlouhy
:
review+
mikepinkerton
:
superreview+
|
Details | Diff | Splinter Review |
The keychain error messages are almost completely useless, we've had a couple of cases now where we needed the error codes to find out what was going on. We should always log the code in the failure message to make debugging easier.
|
Assignee | |
Comment 1•17 years ago
|
||
Attachment #316939 -
Flags: review?(Jeff.Dlouhy)
|
||
Comment 2•17 years ago
|
||
Comment on attachment 316939 [details] [diff] [review]
fix
r=jeff
Attachment #316939 -
Flags: review?(Jeff.Dlouhy) → review+
|
|
Assignee | |
Updated•17 years ago
|
Attachment #316939 -
Flags: superreview?(mikepinkerton)
|
||
Comment 3•17 years ago
|
||
Comment on attachment 316939 [details] [diff] [review]
fix
sr=pink
Attachment #316939 -
Flags: superreview?(mikepinkerton) → superreview+
Given the Keychain-related problems in 1.6, we should take this there.
Flags: camino1.6.1+
|
|
Assignee | |
Comment 5•17 years ago
|
||
Landed on trunk and MOZILLA_1_8_BRANCH.
Status: NEW → RESOLVED
Closed: 17 years ago
Keywords: fixed1.8.1.15
Resolution: --- → FIXED
Target Milestone: --- → Camino2.0
You need to log in
before you can comment on or make changes to this bug.
Description
•