Add error code to Keychain failure logs

RESOLVED FIXED in Camino2.0

Status

RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: stuart.morgan+bugzilla, Assigned: stuart.morgan+bugzilla)

Tracking

({fixed1.8.1.15})

unspecified
Camino2.0
x86
macOS
fixed1.8.1.15
Bug Flags:
camino1.6.1 +

Details

Attachments

(1 attachment)

fix
11.01 KB, patch
Jeff.Dlouhy
: review+
mikepinkerton
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

11 years ago
The keychain error messages are almost completely useless, we've had a couple of cases now where we needed the error codes to find out what was going on. We should always log the code in the failure message to make debugging easier.
(Assignee)

Comment 1

11 years ago
Created attachment 316939 [details] [diff] [review]
fix
Attachment #316939 - Flags: review?(Jeff.Dlouhy)

Comment 2

11 years ago
Comment on attachment 316939 [details] [diff] [review]
fix

r=jeff
Attachment #316939 - Flags: review?(Jeff.Dlouhy) → review+
(Assignee)

Updated

11 years ago
Attachment #316939 - Flags: superreview?(mikepinkerton)
Comment on attachment 316939 [details] [diff] [review]
fix

sr=pink
Attachment #316939 - Flags: superreview?(mikepinkerton) → superreview+
Given the Keychain-related problems in 1.6, we should take this there.
Flags: camino1.6.1+
(Assignee)

Comment 5

11 years ago
Landed on trunk and MOZILLA_1_8_BRANCH.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.1.15
Resolution: --- → FIXED
Target Milestone: --- → Camino2.0
You need to log in before you can comment on or make changes to this bug.