Update blocklist to handle version 2 URL schema

RESOLVED FIXED

Status

()

Toolkit
Blocklisting
RESOLVED FIXED
10 years ago
2 years ago

People

(Reporter: morgamic, Assigned: morgamic)

Tracking

Points:
---
Bug Flags:
blocking-firefox3 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [server side][needed before code freeze])

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
firefox 3 has a new URL schema as defined in bug 430120 and the service needs to be updated to allow it.

The script itself doesn't need to be adjusted, just the apache config.

Current rewrites need to be appended to:
    RewriteRule ^blocklist/(.+)/(.+)/(.+)[/]{0,1}$ services/blocklist.php?reqVersion=$1&appGuid=$2&appVersion=$3 [L]

Dave, can you post a sample blocklist URL here?
I was going to ask you if there was a particular form that you wanted, if not maybe we go with something like this:

https://addons.mozilla.org/blocklist/2/%APP_ID%/%APP_VERSION%/
%PRODUCT%/%BUILD_ID%/%BUILD_TARGET%/%LOCALE%/%CHANNEL%/%OS_VERSION%/%DISTRIBUTION%/%DISTRIBUTION_VERSION%/blocklist.xml

This is basically the same as the current schema with the extra information tacked onto the end.
(Assignee)

Comment 3

10 years ago
Great - thanks Dave!

Updated

10 years ago
Blocks: 430120
Just to confirm what was said on IRC, the blocklist.xml won't be there so the url form will be:

https://addons.mozilla.org/blocklist/2/%APP_ID%/%APP_VERSION%/
%PRODUCT%/%BUILD_ID%/%BUILD_TARGET%/%LOCALE%/%CHANNEL%/%OS_VERSION%/%DISTRIBUTION%/%DISTRIBUTION_VERSION%/
(Assignee)

Comment 6

10 years ago
Created attachment 317442 [details] [diff] [review]
v1, adjusted .htaccess

Jeremy - this lets the version 2 URLs work.  The script ignores params because at the moment they don't dictate any business logic.
Assignee: nobody → morgamic
Status: NEW → ASSIGNED
Attachment #317442 - Flags: review?(oremj)

Comment 7

10 years ago
This blocks a blocker, shouldn't this be "blocking‑firefox3+" then?

Updated

10 years ago
Flags: blocking-firefox3+
Whiteboard: [server side][needed before code freeze]
(Assignee)

Comment 8

10 years ago
Jeremy?
(Assignee)

Comment 9

10 years ago
Comment on attachment 317442 [details] [diff] [review]
v1, adjusted .htaccess

Checked in r12523 -- not scheduled for release until next Thursday (3.4.1).
Attachment #317442 - Flags: review?(oremj)
(Assignee)

Comment 10

10 years ago
Will see if we can push this sooner... AMO doesn't have any scheduled updates until 5/1 though.

Comment 11

10 years ago
Comment on attachment 317442 [details] [diff] [review]
v1, adjusted .htaccess

Rewrites look good.
Attachment #317442 - Flags: review+
(Assignee)

Comment 12

10 years ago
This was pushed this morning...

https://addons.mozilla.org/blocklist/2/%7Bec8030f7-c20a-464f-9b0e-13a3a9e97384%7D/3.0pre/Firefox/2008042309/Darwin_x86-gcc3/en-US/default/Darwin%209.2.2/default/default/
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → Toolkit
You need to log in before you can comment on or make changes to this bug.