430515 - hang and blinking text and checkbox when adding or removing a tag on a history item

Status: VERIFIED WORKSFORME

(Firefox :: Bookmarks & History, defect, P1)

Description

[Tracy Walker [:tracy]]

seen with nightly trunk builds from 20080423

STR:

1. open Library > History > select and item of history
2. in the details view, open the Tag reveal
3. Click a check box to add a tag

Tested results:
The Tag text and the tag check box for that tag blink once then settle into expected tag added state.  

Expected results:
No blinking. just settle into 

performing the same to un-check a tag has the same affect of blinking text and check box then settles into unchecked state.

note: doing this on a bookmakr item doesn't display this behavior.

also note: it is easier to see happen on Mac than on Windows even though my Mac is a faster machine than my Windows box.

Comment 1

[Ria Klaassen (not reading all bugmail)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008042400 Minefield/3.0pre

Hm, it hangs like crazy here for about 80 seconds with changing CPU usage. At the end the Library disappears a few times to the background and sometimes the Firefox and Library taskbar buttons disappear completely from the taskbar, as you can see on this screenshot: 
http://img247.imageshack.us/img247/8030/screenshothl7.jpg
The taskbar button that is visible on the screenshot belongs to another browser.

Comment 2

[Dietrich Ayala (:dietrich)]

i got the hang also.

looks like maybe the whole view is being refreshed when whatever event is received for query items when a tag is changed. since the query is for all of history, i thought maybe that was the cause, but loading the history view initially doesn't take nearly as long.

bumping priority, clarifying summary.

Comment 3

[Marco Bonardo [:mak]]

see also bug 460830, tag query has a wrong history observer, so that could also be related.

Comment 4

[Tracy Walker [:tracy]]

WFM now

Comment 5

[Tracy Walker [:tracy]]

sorry, this isn't wfm, It works for adding a tag via the check box, but when you uncheck tag box it flickers off/on/off and the text flickers as well.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

It still flickers for me when adding a tag via the checkbox with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20081212 Minefield/3.2a1pre ID:20081212040742

Comment 7

[Marco Bonardo [:mak]]

i cannot reproduce on latest trunk, could you provide updated steps to see this please?

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Yes, it has been fixed by an unknown patch between 01/01 and 01/13. Tracy, can you verify?

Comment 9

[Tracy Walker [:tracy]]

 yep, WFM for add and remove of tag with check box. no flickering using a nightly shiretoko build

Comment 10

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv