430603 - Welcome to firefox image on Firefox 3 firstrun pages is not localizable

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[Pascal Chevrel:pascalc]

the "welcome to firefox" image on the firstrun pages is part of the CSS file and cannot be changed for locales. The css trick based on text-indent to hide the real text in <h2> also does not work with RTL languages.

https://he.www-firefox3.authstage.mozilla.com/he/firefox/3.0/firstrun/
https://he.www-firefox3.authstage.mozilla.com/img/tignish/firstrun/welcome.png

https://he.www-firefox3.authstage.mozilla.com/style/tignish/firstrun-page.css
#main-feature h2 {
	background: url(/img/tignish/firstrun/welcome.png) 0 10px no-repeat;
	text-indent: -9999px;
	margin-left: 235px;
	padding: 20px 0 100px 0;
}

The css used should be more clever to display images according to the locale of the page or the images should be called from HTML.

Comment 1

[Steven Garrity [:sgarrity]]

Pascal - I'm agreed that we shouldn't be using the text-indent on this.

Would it work for you if we just do an image-based title (<img...>, not a CSS background) per-locale?

Or maybe do the "Welcome to" as real text, and the "Firefox 3" as an image? Or does that assume the order of the text will be the same in all locales?

Comment 2

[Pascal Chevrel:pascalc]

<h2><img src="/ab-CD/img/welcome.png" alt="welcome to Firefox 3"/></h2> is what I prefer.

 I do not have to ask localizers to redo the work since the string is already in the <h2>.

If we do not have the image localized, the alternative localized text will be displayed.

Comment 3

[Pascal Chevrel:pascalc]

Steven, could you remove the CSS rules asap ? I need to put the <img> tags and localized graphics.

Comment 4

[Steven Garrity [:sgarrity]]

Pascal: Fixed in r12594.

Let me know if you need anything else for this.

Comment 5

[Pascal Chevrel:pascalc]

thanks

Comment 6

[Pascal Chevrel:pascalc]

tested with french locale, verified