430607 - "visit mozilla.com" string in l10n in-product pages is not localizable

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[Pascal Chevrel:pascalc]

The string "visit mozilla.com" is hardcoded in header-portal-pages.inc.php

<a href="/{$lang}/" id="return">Visit Mozilla.com</a>

Should be:

<a href="/{$lang}/" id="return">{$GLOBALS['__l10n_moz']['Visit Mozilla.com']}</a>

It's outside of the locales folders but I can patch the file if the webdevs are too busy.

Comment 1

[Steven Garrity [:sgarrity]]

Updated in r12487.

Comment 2

[Wil Clouser [:clouserw]]

(In reply to comment #1)
> Updated in r12487.
> 

> <a href="/{$lang}/" id="return">{$GLOBALS['__l10n_moz']['Visit Mozilla.com']}</a>

This isn't a good way to do this because fallback is broken (bug 433993).  The way we want to do strings like this (and if you see others on the site please change it) is {$l10n->get('Visit Mozilla.com')}.  This syntax is php5-only, btw.

Comment 3

[Pascal Chevrel:pascalc]

we are keeping the string in English for the release as it is also a good indicator that the main site is not in the visitors language, but we indeed need it on the long term, and I would also like to have something like :

Visit Mozilla China / Visit mozilla.com

with the first string in Chinese, same for European locales.

Comment 4

[Laura Forrest]

Doing a bit of bug housekeeping here and came across this. 

Closing for now since this hasn't been updated in 3 years. If you think this is still important to fix, and applies to the current mozilla.com, please re-open. Thanks!

Comment 5

[Pascal Chevrel:pascalc]

was fixed a long time ago, although we currently do not use this string