43075 - Hard coded plugin content type strings in nsLayoutDLF break external helper apps

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P3)

Description

[Scott MacGregor]

I'm implementing Bug #38374  for launching external helper applications for
content types we can't handle.


I've run into a problem which blocks that bug from working correctly for a
certain set of content types.

In nsLayoutDLF.cpp there is a had coded list of content types for plugins:

// XXX temporary
static char* gPluginTypes[] = {
  "video/quicktime",
  "video/msvideo",
  "video/x-msvideo",
  "application/vnd.netfpx",
  "image/vnd.fpx",
  "model/vrml",
  "x-world/x-vrml",
  "audio/midi",
  "audio/x-midi",
  "audio/wav",
  "audio/x-wav",
  "audio/aiff",
  "audio/x-aiff",
  "audio/basic",
  "application/x-shockwave-flash",
  "application/npapi-test",
  0
};

 layout registers a progid for each of these content types so it now thinks it
can create a content viewer for any of these regardless of whether we actually
HAVE a plugin for that type.

Now, when you click on a url that has one of these content types, layout says it
can handle it and trys to. However, if you don't have a plugin installed for
that type, we get an empty screen (because layotu can't create a nsPresContext
for the document) and on occasion I crash.

Why is this problem: because layout incorrectly says it can handle these content
types, we never reach the point where we would invoke a helper application. So
this bug prevents the launching of acrobat if you click on  .pdf file or quick
time if you click on a quick time url.

Comment 1

[Scott MacGregor]

nominating for nsbeta2. This partially blocks the functionality of the feature
exception bug: 38374.

I believe we need to only add entries in the registry for plugin content types
we actually have plugins for on the user's machine and not a hard coded list.

Comment 2

[Peter Trudelle]

nsbeta2+

Comment 3

[av (gone)]

Reassigning as per agreement.

Comment 4

[Scott MacGregor]

Hey Alex, what do you think the ramifications are if we just deleted this table?
Or could I at least delete the pdf entry in this table? PDF is a common test
case for showing off helper application support. I was wondering if I could
delete that entry so people trying out helper apps could see it work.

Comment 5

[av (gone)]

Back to me.

Comment 6

[av (gone)]

Fix checked in. Now plugin types are given by the plugin host object.

Comment 7

[shrirang khanzode]

verified with acrobat that this is working (2000071108)