430754 - Tips page has harcoded English strings in an external javascript file

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[Pascal Chevrel:pascalc]

Attachment: screenshot showing English text in Greek page

See image attache for illustration.

The tip page slider says "1 of 5" and arrow images have "previous" and "next" tooltips hardcoded into an external javacript file :

http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/branches/firefox3/js/mozilla-pager.js?revision=12472&view=markup

Mozilla.Pager.NEXT_TEXT         = 'Next';
Mozilla.Pager.PREV_TEXT         = 'Previous';
Mozilla.Pager.PAGE_NUMBER_TEXT  = '%s of %s';

We should never ever have English strings in files that localizers can't access, all locales are affected by this. These strings should be defined in the html files that localizers can modify...

Please fix the en-US copy, thanks.

Comment 1

[Steven Garrity [:sgarrity]]

Fixed in r13179.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot of English tooltip on Greek [el] page

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Reopening; Pascal, do you need to do something on your end to work with Steven's fixes?

Comment 4

[Pascal Chevrel:pascalc]

closing, not all locales on mozilla europe have included the new strings yet, but Steven's fix works. We are using 1/5 instead of 1 of 5 which was the most obvious string.

You can see on the German page that it works:
https://stage.mozilla-europe.org/de/firefox/tips/

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using http://www.mozilla-europe.org/el/firefox/tips/.