430755 - Tips page has harcoded english text in an image displayed by javascript

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

The Fx3 Tips page displays the string "middle click" by javascript inserting an image (??) that is actually the text.

https://fr.www-firefox3.authstage.mozilla.com/en-US/img/tignish/tips/new-tab-click.png

<?=buildPlatformImage('/en-US/img/tignish/tips/new-tab-click.png', 'Middle Click on link (mac: ⌘ + click on link)', '132', '37')?>


Why should we create png images of "middle-click" instead of *writing* middle-click ? And why is the alternate text for the image different from the text we put in the image?

Comment 1

[Steven Garrity [:sgarrity]]

Fixed in r12820.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Reopening; I still see it for Mac:

https://fr.www-firefox3.authstage.mozilla.com/en-US/img/tignish/tips/new-tab-click-mac.png

Comment 3

[Steven Garrity [:sgarrity]]

(In reply to comment #2)
> Reopening; I still see it for Mac:

We're still using images for the keyboard shortcuts with key-images in them, just not the ones that are all text ("Middle-click on link"), so the Mac version should probably stay as is (since it has the Apple key image).