430785 - Caret not visible with right-clicking on a text input

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect)

Description

[Martijn Wargers (dead)]

Attachment: patch

When right-clicking on a text control, the caret hides. This is annoying, since you don't where the text will be pasted to when you want to do a paste operation.
This regressed between 2008-03-31 and 2008-04-01:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2008-03-31+04&maxdate=2008-04-01+09&cvsroot=%2Fcvsroot
I think a regression from bug 420499.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Isn't the caret *supposed* to be hidden when a menu pops up?

Comment 2

[Martijn Wargers (dead)]

No, not for tooltips nor for context menus.
IE nor Opera hides the caret for context menus.
In fact, IE makes the caret non-blinking in that case, which is even nicer.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

OK. Chris, should be an easy fix to ignore context menus and tooltips in your code, but we need it fast.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 317692 [details] [diff] [review]
patch

oh, never mind!

This is good, but should we test for tooltips too?

This can land on its own, though. Simple safe fix for a regression.

Comment 5

[Neil Deakin]

Comment on attachment 317692 [details] [diff] [review]
patch

>+      $("contextmenu").showPopup($('text-input'), -1 , -1 , "context", "bottomleft", "topleft" );

Please use openPopup rather than the old and confusing showPopup method.

This looks ok to me too.

Comment 6

[Damon Sicore (:damons)]

Comment on attachment 317692 [details] [diff] [review]
patch

a1.9+=damons

Comment 7

[Martijn Wargers (dead)]

Attachment: updated patch, ready for check-in

Patch, with updated mochitest, using openPopup now and also testing tooltip popup.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

mozilla/layout/base/nsCaret.cpp 	1.193
mozilla/layout/base/tests/test_bug420499.xul 	1.2