43079 - nsImapSearchResultSequence::Clear() crashes when the imap connection was cancled

Status: VERIFIED FIXED

(MailNews Core :: Networking: IMAP, defect, P3)

Description

[Stuart Parmenter]

nsImapSearchResultSequence::Clear() crashes when the imap connection was
cancled.  mImpl is null.

patch (without whitespace changes):

Index: nsImapSearchResults.cpp
===================================================================
RCS file: /cvsroot/mozilla/mailnews/imap/src/nsImapSearchResults.cpp,v
retrieving revision 1.5
diff -u -b -w -r1.5 nsImapSearchResults.cpp
--- nsImapSearchResults.cpp	2000/06/13 08:33:19	1.5
+++ nsImapSearchResults.cpp	2000/06/19 21:06:42
@@ -44,12 +44,14 @@
 
 void nsImapSearchResultSequence::Clear(void)
 {
+    if (mImpl) {
   PRInt32 i = mImpl->mCount;
   while (0 <= --i) {
     char* string = (char*)mImpl->mArray[i];
     delete string;
   }
   nsVoidArray::Clear();
+    }
 }
 
 nsImapSearchResultSequence::~nsImapSearchResultSequence()

Comment 1

[Stuart Parmenter]

this happens when you don't login to the default server and you try and change
to a different server.

Comment 2

[leger]

Putting on [dogfood-][nsbeta2+] radar.

Comment 3

[Stuart Parmenter]

checked in fix

Comment 4

[lchiang]

We can test this in the UI by:
1. 2 IMAP accounts
2. When prompted to log into the first account, cancel the password dialog
3. Select the second IMAP account and login
Right?

Comment 5

[Stuart Parmenter]

yes, that should do it.

Comment 6

[Karen Huang]

By using Linux 07-26-08-M17 Commercial build

Verified that there are no crashes for the second IMAP connection when canceling 
the first IMAP connection. 
Marking as verified!!

Comment 7

[Daniel Veditz [:dveditz]]

Adding keyword to bugs which already show a nsbeta2 triage value in the status 
whiteboard so the queries don't get screwed up.