Closed Bug 430809 Opened 17 years ago Closed 15 years ago

Performance improvement opportunity when parsing entities

Categories

(Core :: DOM: HTML Parser, enhancement)

Product:
Core
Component:
DOM: HTML Parser
Platform:
x86
All
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.3a5

People

(Reporter: danielgutson, Assigned: danielgutson)

References

Details

(Keywords: perf, Whiteboard: [fixed by the HTML5 parser])

User-Agent: Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 1.1.4322) Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5) Each entity token triggers two accesses to the hash table: one for checking if the entity is valid, and a second one for getting the unicode. (in two different places of the code). The unicode can be cached the first time in order to avoid the second hash access. Reproducible: Always Steps to Reproduce: 1. Open a page containing &xxxx entities. Actual Results: hash table is accessed twice Expected Results: Could cache the unicode when the entity code is valid Feel free to assign this bug to me
Depends on: 427240
Component: General → HTML: Parser
Keywords: perf
Product: Firefox → Core
QA Contact: general → parser
Version: unspecified → Trunk
Assignee: nobody → danielgutson
The HTML5 parser does the lookup once. (Without a hashtable.)
Status: UNCONFIRMED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [fixed by the HTML5 parser]
Target Milestone: --- → mozilla1.9.3a5
You need to log in before you can comment on or make changes to this bug.