430862 - create a test for excludeReadOnlyFolders query option

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[cmtalbert]

Attachment: test for the readonly folder problem

The excludeReadOnlyFolders option is not excluding readonly folders from the query.

1. Put two bookmarks into database - one in a normal folder, one in a folder with readonly set
2. Create a test that uses excludeReadOnlyFolders
3. Check the result of the query

== Expected ==
Only get the normal bookmark returned in the query

== Actual ==
Get both bookmarks returned in the result set.

Attaching a testcase for the issue.

Comment 1

[cmtalbert]

Attachment: Proper header files for the test

This header file is the proper header file to use.  There is an issue with the header file in the tree.

Comment 2

[Marco Bonardo [:mak]]

excludeReadOnlyFolders does exclude folders from a result, not uris, even if they are descendant of a read-only folder. so the test is expected to fail. An option to do the above could be excludeIfParentReadOnly, but that'd be a separate bug, if needed.

morphing this bug to create a proper test for excludeReadOnlyFolders since we don't have one.

Comment 3

[Marco Bonardo [:mak]]

Attachment: updated test

fixed version of the test

Comment 4

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/5f1882e23b39

Comment 5

[Marco Bonardo [:mak]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/af014e5f304a

Comment 6

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv