create a test for excludeReadOnlyFolders query option

RESOLVED FIXED in Firefox 3.7a1

Status

()

defect
RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: cmtalbert, Assigned: mak)

Tracking

Trunk
Firefox 3.7a1
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(status1.9.2 beta1-fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

The excludeReadOnlyFolders option is not excluding readonly folders from the query.

1. Put two bookmarks into database - one in a normal folder, one in a folder with readonly set
2. Create a test that uses excludeReadOnlyFolders
3. Check the result of the query

== Expected ==
Only get the normal bookmark returned in the query

== Actual ==
Get both bookmarks returned in the result set.

Attaching a testcase for the issue.
Posted file Proper header files for the test (obsolete) —
This header file is the proper header file to use.  There is an issue with the header file in the tree.
Blocks: 384226
No longer depends on: 384226
Blocks: 509868
excludeReadOnlyFolders does exclude folders from a result, not uris, even if they are descendant of a read-only folder. so the test is expected to fail. An option to do the above could be excludeIfParentReadOnly, but that'd be a separate bug, if needed.

morphing this bug to create a proper test for excludeReadOnlyFolders since we don't have one.
Summary: excludeReadOnlyFolders query option does not exclude ReadOnly Folders → create a test for excludeReadOnlyFolders query option
Posted patch updated testSplinter Review
fixed version of the test
Assignee: nobody → mak77
Attachment #317765 - Attachment is obsolete: true
Attachment #317766 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #394967 - Flags: review?(dietrich)
Attachment #394967 - Flags: review?(dietrich) → review+
http://hg.mozilla.org/mozilla-central/rev/5f1882e23b39
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a1
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.