Closed Bug 430883 Opened 12 years ago Closed 12 years ago
NSPR does not need to link with libthread on Solaris
In the pthread configuration (USE_PTHREADS), NSPR does not need to link with libthread, only libpthread. libpthread is actually a filter library for libthread.
I checked this patch on Solaris 10 x86 and Solaris 8 Sparc.
Assignee: wtc → julien.pierre.boogz
Status: NEW → ASSIGNED
Attachment #317812 - Flags: review?(wtc)
Priority: -- → P2
Target Milestone: --- → 4.7.1
Version: other → 4.7
Comment on attachment 317812 [details] [diff] [review] don't link with libthread if USE_PTHREADS is set r=wtc. I remember we had to link with -lpthread -lthread when we used GCC. Or it's possible that the pthread_create man page on older versions of Solaris told us to link with -lpthread -lthread.
Attachment #317812 - Flags: review?(wtc) → review+
Thanks for the review, Wan-Teh. I checked the patch in to the NSPR trunk for 4.7.1 . Checking in pr/src/Makefile.in; /cvsroot/mozilla/nsprpub/pr/src/Makefile.in,v <-- Makefile.in new revision: 1.46; previous revision: 1.45 done Checking in pr/tests/Makefile.in; /cvsroot/mozilla/nsprpub/pr/tests/Makefile.in,v <-- Makefile.in new revision: 1.51; previous revision: 1.50 done
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.