43089 - nsChromeRegistry::GetProfileRoot uses filelocator!

Status: RESOLVED FIXED

(Core :: XUL, defect, P3)

Description

[Doug Turner (:dougt)]

Instead of using the filelocator, you should use the nsDirectoryService.  The 
reason for this is that the filelocator requires the appshell crap whereas the 
directoryservice is built into xpcom.





nsChromeRegistry::GetProfileRoot(nsCString& aFileURL) 
{ 
  nsCOMPtr<nsIFileLocator> fl;
  
  nsresult rv = 
nsComponentManager::CreateInstance("component://netscape/filelocator",
                                          nsnull,
                                          NS_GET_IID(nsIFileLocator),
                                          getter_AddRefs(fl));

Comment 1

[Judson Valeski]

-> nsbeta2. moving to m16. we're hammering out dependency issues and this is low 
hanging fruit.

Comment 2

[David Hyatt]

Then reassign it to someone else.  I don't have time in M16 to deal with this 
issue.

Comment 3

[Judson Valeski]

-> jud

Comment 4

[Mike]

M16 has been out for a while now, these bugs target milestones need to be 
updated.

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

m17 is out now, please update target

Comment 6

[Judson Valeski]

over to conrad.

Comment 7

[Conrad Carlen (not reading bugmail)]

Fixed with
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/rdf/chrome/src&command=DIFF_FRAMESET&file=nsChromeRegistry.cpp&rev2=1.162&rev1=1.161
Missed marking it somehow :-/