430901 - The checkbox in the Tools>Options menu, under the Privacy tab, the "Keep my History for at least X days" will not save any changes, and remains unchecked.

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[maru taku]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5) Gecko/2008032620 Firefox/3.0b5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5) Gecko/2008032620 Firefox/3.0b5

Attempting to allow Firefox to record the history or browsed sites results in failure.

Reproducible: Always

Steps to Reproduce:
1.Check box
2.Click OK, then close
3.Reopen
Actual Results:  
Preference was not saved.


My version of Firefox is vanilla, no addons downloaded.

Comment 1

[David Humphrey (:humph)]

Confirmed on mac

Comment 2

[David Humphrey (:humph)]

Attachment: privacy.js patch to deal with case of mirror=0

The problem here is that browser.history_expire_days and browser.history_expire_days.mirror can both be 0 if the user previously had no history being kept, and so when this code is executed onChange:

pref.value = checkbox.checked ? mirror.value : 0;

the result is pref.value is always 0, and the value is never updated.  This fixes it by using the default min days value in the case that pref==mirror==0.

For those suffering from this bug (like me!), a work around is to set the following prefs manually in about:config

browser.history_expire_days=180
browser.history_expire_days.mirror=180

Comment 3

[Dietrich Ayala (:dietrich)]

Comment on attachment 325802 [details] [diff] [review]
privacy.js patch to deal with case of mirror=0

r=me, thanks sir!

Comment 4

[Mike Shaver (:shaver emeritus)]

Comment on attachment 325802 [details] [diff] [review]
privacy.js patch to deal with case of mirror=0

Please land this on CVS as well!

Comment 5

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/preferences/privacy.js 	1.27

Comment 6

[Hasham]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.1) Gecko/2008070206 Firefox/3.0.1

Verified on 1.9.0.1 branch. Firefox remembers that setting.

Comment 7

[Christian Scorsese]

This bug does not happen to me.

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.0.1) Gecko/2008070208 Firefox/3.0.1 ID:2008070208

Comment 8

[David Humphrey (:humph)]

(In reply to comment #7)
> This bug does not happen to me.

Well, you're not trying hard enough:

- New profile
- browser.history_expire_days = 0
- browser.history_expire_days.mirror = 0
- Enable history, close dialog, re-check value

It can't *not* happen, given the current code.  It's not a Mac vs. Windows thing.

Comment 9

[(mostly gone) XtC4UaLL [:xtc4uall]]

is this going to land on trunk too?

Comment 10

[Reed Loden [:reed]]

Pushed in 15860:3a01d5cb3a5e.