Closed Bug 430905 Opened 12 years ago Closed 12 years ago

Sidebars and toolbars should use closeSidebar.png

Categories

(Firefox :: Theme, defect)

All
Windows XP
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 3

People

(Reporter: faaborg, Assigned: ehsan)

References

Details

Attachments

(1 file)

To appear more platform native and to give the application a slightly simpler appearance, sidebars (bookmarks, history) and toolbars (find) should use the file closeSidebar.png for the close button instead of the same icon used for closing tabs.

This change can apply to both both Luna and Aero, although currently closeSidebar-aero.png is identical to close-aero.png since aero already uses a simpler close button for tabs.

icons:

toolkit/themes/winstripe/global/icons/closeSidebar.png
toolkit/themes/winstripe/global/icons/closeSidebar-aero.png
I don't remember the code notation you guys use, but since the new closeSidebar.png files have landed in the latest nightly, it is easy enough to get the sidebar to use the new file by adding 'list-style-image: url("chrome://global/skin/icons/closeSidebar.png");' to the "#sidebar-box .tabs-closebutton" entry in the browser.css file like so:


#sidebar-box .tabs-closebutton {
  list-style-image: url("chrome://global/skin/icons/closeSidebar.png");
  margin-bottom: 0px !important;
  padding: 0px 0px 0px 0px !important;
}
Attached patch Patch (v1)Splinter Review
Trivial patch.
Assignee: nobody → ehsan.akhgari
Status: NEW → ASSIGNED
Attachment #317861 - Flags: review?(gavin.sharp)
Comment on attachment 317861 [details] [diff] [review]
Patch (v1)

Should #textbox-input-closebutton in organizer.css (bookmarks organizer search box close button) also use this new button? What about messageCloseButton in notification.css (notification bar close message)?

It would also be nice to file bugs against other users of close.png (calendar, composer) to let them know of the new images available for sidebar-specific close buttons.
Attachment #317861 - Flags: review?(gavin.sharp) → review+
Comment on attachment 317861 [details] [diff] [review]
Patch (v1)

Trivial patch to use an icon which lands in bug 430759.
Attachment #317861 - Flags: approval1.9?
This should land after bug 430759.
Depends on: 430759
#textbox-input-closebutton

This should be Search-close.png and Search-close-aero.png, filed bug 431002
Comment on attachment 317861 [details] [diff] [review]
Patch (v1)

a=mconnor on behalf of 1.9 drivers
Attachment #317861 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
(In reply to comment #3)
> What about messageCloseButton in notification.css (notification bar close
> button)?

Alex, do you have any thoughts about whether these should use the sidebar close buttons? It would be trivial to adjust the patch here to cover those as well, before landing.
I went ahead and landed this patch, can change the notification bar close buttons in a new bug if desired.

mozilla/browser/themes/winstripe/browser/browser.css 	1.209
mozilla/toolkit/themes/winstripe/global/findBar.css 	1.10 
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3
We are going to need a new file for the notification bars if we use the gradients over in 423744, otherwise we should switch to closeSidebar.  I'll try to get that sorted out over in that bug momentarily.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008042911 Minefield/3.0pre


#sidebar-box .tabs-closebutton {
+  list-style-image: url("chrome://global/skin/icons/closeSidebar.png");
   margin-bottom: 0px !important;
   padding: 0px 2px 0px 2px !important;
}

.tabs-closebutton, where is this ?
screenshot : http://img292.imageshack.us/img292/8830/tccf8.jpg
(In reply to comment #11)
> #sidebar-box .tabs-closebutton {

> .tabs-closebutton, where is this ?
> screenshot : http://img292.imageshack.us/img292/8830/tccf8.jpg

Not sure what you mean. "#sidebar-box .tabs-closebutton" styles the sidebar close button.
sorry, I misunderstood it.
I thought it is for close button on each tab.
You need to log in before you can comment on or make changes to this bug.