Closed Bug 430907 Opened 12 years ago Closed 12 years ago

Refresh flexible space icon in the toolbar customization palette (Windows, Linux)

Categories

(Firefox :: Theme, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 3

People

(Reporter: faaborg, Assigned: ehsan)

References

Details

Attachments

(3 files, 2 obsolete files)

Bug 430759 will land new icons to be used for "flexible space" in the toolbar customization palette on XP and Vista:

toolkit/themes/winstripe/global/toolbar/spring-aero.png
toolkit/themes/winstripe/global/toolbar/spring.png

if the tango theme would like to refresh this icon as well it should be placed in a similar location in gnomestripe.  A small amount of work is required for this update since the current file is a gif, and the new file a png.
Attached patch Patch (v1) (obsolete) — Splinter Review
Simple patch.
Assignee: nobody → ehsan.akhgari
Status: NEW → ASSIGNED
Attachment #317852 - Flags: review?(gavin.sharp)
Comment on attachment 317852 [details] [diff] [review]
Patch (v1)

spring.png/spring-aero.png haven't landed yet, and you'll need to also changes gnomestripe's toolbar.css to avoid breaking it.
Attachment #317852 - Flags: review?(gavin.sharp) → review-
Attached patch Patch (v1.1) (obsolete) — Splinter Review
> spring.png/spring-aero.png haven't landed yet

Yes, they'll land in bug 430759, which is a dependency of this bug.  I'll request check-in on this bug after the icons land in bug 430759.

> and you'll need to also changes
> gnomestripe's toolbar.css to avoid breaking it.

Done.
Attachment #317920 - Flags: review?(gavin.sharp)
Whiteboard: [bug 430759 should land before this bug]
Whiteboard: [bug 430759 should land before this bug]
Attached image source SVG for tweaking
Comment on attachment 318113 [details]
source SVG for tweaking

Does this have/need approval?
Whiteboard: [has patch] [needs review gavin]
Attachment #318112 - Flags: ui-review?(faaborg)
Attachment #318112 - Flags: ui-review?(faaborg) → ui-review+
Attachment #318112 - Flags: approval1.9?
Attachment #318112 - Flags: approval1.9? → approval1.9+
Comment on attachment 317920 [details] [diff] [review]
Patch (v1.1)

>Index: toolkit/themes/winstripe/global/jar.mn

>-        skin/classic/global/toolbar/spring.gif                   (toolbar/spring.gif)
>+        skin/classic/global/toolbar/spring.png                   (toolbar/spring.png)

Let's just add the .png and keep the .gif in case there are existing toolkit users (probably unlikely, but doesn't really hurt at this point).

Looks like the addition of the png to this jar.mn already landed as part of the icon drop, so no need to make any changes to jar.mn.
Attachment #317920 - Flags: review?(gavin.sharp) → review+
Keywords: checkin-needed
Whiteboard: [has patch] [needs review gavin] → [has patch]
Jakub, nice, btw can you round up the arrows a bit, so we don't end up with those too dark corners?
Attached patch patchSplinter Review
This is what I landed.

mozilla/toolkit/themes/gnomestripe/global/jar.mn 	1.42
mozilla/toolkit/themes/gnomestripe/global/toolbar.css 	1.15
mozilla/toolkit/themes/gnomestripe/global/toolbar/spring.png 	1.1
mozilla/toolkit/themes/winstripe/global/toolbar.css 	1.20
Attachment #317852 - Attachment is obsolete: true
Attachment #317920 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [has patch]
Target Milestone: --- → Firefox 3
You need to log in before you can comment on or make changes to this bug.