430962 - Go button is way too small compared to other buttons (e.g., Star and RSS icons)

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect)

Description

[u88484]

Attachment: Screenshot

The new Go button that landed today via bug 430759 made the Go button way too small compared to other buttons (e.g., Star and RSS icons).  The Go button is now dwarfed compared to the others and the visual click area is almost non-existent.  This is on both XP and Vista.

Comment 1

[Matt Cosentino]

The icon isn't the problem, there is vertical padding that causes it to shrink.  It was even more noticeable with the previous icon.

Comment 2

[u88484]

Attachment: Previous and current Go arrow

(In reply to comment #1)
> The icon isn't the problem, there is vertical padding that causes it to shrink.
>  It was even more noticeable with the previous icon.
> 

So you trying to say that checking in a new png for the go button, altered the vertical padding and somehow miraculously all around shrunk the go button by a few pixels around the entire arrow?

See attachment for comparisons between the previous version (arrow on left) and current version (arrow on right).

Comment 3

[Kris Silver]

This needs addressing, it's an important icon that's now dramatically too small, and inconsistent with the other icons that even appear there.  The previous icon should be re instated.

Comment 4

[Matt Cosentino]

Attachment: Size comparison of icon with how it is currently displayed.

Here, I added the actual icon next to how it currently looks, see how it was shrunk by 1 pixel?

Comment 5

[u88484]

Attachment: More comparisons

Comment 6

[u88484]

(In reply to comment #4)
> Created an attachment (id=317911) [details]
> Size comparison of icon with how it is currently displayed.
> 
> Here, I added the actual icon next to how it currently looks, see how it was
> shrunk by 1 pixel?
> 

Yeah, I noticed that when I first downloaded the zip that Alex Faaborg supplied in the other bug.  It will still too small though once the issue you are describing is fixed.

Comment 7

[Matt Cosentino]

I think the size is perfect, at least on Vista.  The lines are the same width as the search glass, which I believe was the intention.  The previous icon was too big in my opinion.

Comment 8

[Dão Gottwald [:dao]]

(In reply to comment #0)
> Created an attachment (id=317894) [details]
> Screenshot
> 
> The new Go button that landed today via bug 430759 made the Go button way too
> small compared to other buttons (e.g., Star and RSS icons).

That comparison is moot. You shouldn't see Go and the other icons at the same time.

Comment 9

[u88484]

Forgot about that but still, then there is just a very skinny, small button at the end of the location bar that doesn't stand out that much and visually does not have a big click area or however you guys explain that.  Also since it is so small, it is hard to distinguish between the change in colors when hovering over the icon.  I just can't believe it will be going from Firefox 2.0's size to this minute thing.

Comment 10

[Alex Faaborg [:faaborg] (Firefox UX)]

We want the go button to match the line width and color of the search button on Vista.  We need to remove the padding so that the icon isn't squished from the original size.  Target area remains the same, so there is no usability implication.  Given how far this thing is from the text the user is actually entering, the icon remains largely useless regardless of a 2 pixel vs. 3 pixel line width.

Comment 11

[Kai Liu]

The patch in bug 406894 will address the issue of the image being vertically compressed.

Comment 12

[Kai Liu]

Just wondering aloud here; has the possibility of keeping the icon as-is for Vista, but restoring the larger icon for XP been considered?  I agree that the thinner icon looks better with the Vista search glass, but that thin search glass doesn't exist on XP.

Comment 13

[Alex Faaborg [:faaborg] (Firefox UX)]

I'll talk to beltzner about that to see what he thinks.

Comment 14

[:Gijs (out for now; he/him)]

We've changed the icons a gazillion number of times since this bug got filed, and the current icon looks fine to me, so going to mark this as wfm. :-)