Closed
Bug 430980
Opened 17 years ago
Closed 17 years ago
Don't package help viewer theme/locale files
Categories
(SeaMonkey :: Help Viewer, defect)
SeaMonkey
Help Viewer
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.1a2
People
(Reporter: Gavin, Assigned: steffen.wilberg)
Details
Attachments
(1 file)
|
1.42 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
There are a bunch of CSS/image files in toolkit/themes/winstripe/help and toolkit/themes/pinstripe/help that aren't needed when the help viewer isn't built. We should package them only when MOZ_HELP_VIEWER is defined.
|
Assignee | |
Comment 1•17 years ago
|
||
Hi Gavin, you asked for it, you review it ;-)
Assignee: jwalden+fxhelp → steffen.wilberg
Status: NEW → ASSIGNED
Attachment #333110 -
Flags: review?(gavin.sharp)
|
|
Assignee | |
Comment 2•17 years ago
|
||
Let's not ship another release with a bunch of unused images.
Flags: blocking1.9.1?
|
Reporter | |
Comment 3•17 years ago
|
||
Comment on attachment 333110 [details] [diff] [review]
add some "ifdef MOZ_HELP_VIEWER"
Thanks, Steffen :)
Can you ifdef http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/locales/jar.mn&rev=1.48&mark=110-114#110 too while you're at it? Or file a new bug...
Attachment #333110 -
Flags: review?(gavin.sharp) → review+
|
|
Assignee | |
Comment 4•17 years ago
|
||
Sure.
Summary: Don't package help viewer CSS/image files ifndef MOZ_HELP_VIEWER → Don't package help viewer theme/locale files
|
|
Assignee | |
Comment 5•17 years ago
|
||
http://hg.mozilla.org/mozilla-central/index.cgi/rev/41d4ac0abf02
http://hg.mozilla.org/mozilla-central/index.cgi/rev/3d7ff51f7a4a
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•17 years ago
|
Flags: blocking1.9.1?
Target Milestone: --- → mozilla1.9.1a2
|
||
Updated•9 years ago
|
Product: Toolkit → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•