The default bug view has changed. See this FAQ.

Don't package help viewer theme/locale files

RESOLVED FIXED in mozilla1.9.1a2

Status

SeaMonkey
Help Viewer
RESOLVED FIXED
9 years ago
a year ago

People

(Reporter: Gavin, Assigned: Steffen Wilberg)

Tracking

Trunk
mozilla1.9.1a2

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

There are a bunch of CSS/image files in toolkit/themes/winstripe/help and toolkit/themes/pinstripe/help that aren't needed when the help viewer isn't built. We should package them only when MOZ_HELP_VIEWER is defined.
(Assignee)

Comment 1

9 years ago
Created attachment 333110 [details] [diff] [review]
add some "ifdef MOZ_HELP_VIEWER"

Hi Gavin, you asked for it, you review it ;-)
Assignee: jwalden+fxhelp → steffen.wilberg
Status: NEW → ASSIGNED
Attachment #333110 - Flags: review?(gavin.sharp)
(Assignee)

Comment 2

9 years ago
Let's not ship another release with a bunch of unused images.
Flags: blocking1.9.1?
Comment on attachment 333110 [details] [diff] [review]
add some "ifdef MOZ_HELP_VIEWER"

Thanks, Steffen :)

Can you ifdef http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/locales/jar.mn&rev=1.48&mark=110-114#110 too while you're at it? Or file a new bug...
Attachment #333110 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 4

9 years ago
Sure.
Summary: Don't package help viewer CSS/image files ifndef MOZ_HELP_VIEWER → Don't package help viewer theme/locale files
(Assignee)

Comment 5

9 years ago
http://hg.mozilla.org/mozilla-central/index.cgi/rev/41d4ac0abf02
http://hg.mozilla.org/mozilla-central/index.cgi/rev/3d7ff51f7a4a
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Assignee)

Updated

9 years ago
Flags: blocking1.9.1?
Target Milestone: --- → mozilla1.9.1a2
Product: Toolkit → Seamonkey
You need to log in before you can comment on or make changes to this bug.