431013 - FTP view is not using new folder icons on XP and Vista

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Screen shots of Vista, XP and OS X

The folders in our ftp view need to be refreshed to the new icons:

Vista folder:
http://mxr.mozilla.org/seamonkey/source/toolkit/themes/winstripe/global/dirListing/local-aero.png

Vista remote computer:
http://mxr.mozilla.org/seamonkey/source/toolkit/themes/winstripe/global/dirListing/remote-aero.png

XP Folder:
http://mxr.mozilla.org/seamonkey/source/toolkit/themes/winstripe/global/dirListing/local.png

OS X remote computer:
http://mxr.mozilla.org/seamonkey/source/toolkit/themes/pinstripe/global/dirListing/remote.png

Are all of these images stored in cdata somewhere?  It would be useful to have a list of icons that don't get refreshed just by landing the new ones.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

These aren't updated because of bug 388553. Need to update the hardcoded images at http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/netwerk/streamconv/converters/nsIndexedToHTML.cpp&rev=1.92#475 .

Comment 2

[Alex Faaborg [:faaborg] (Firefox UX)]

What are the limitations for platform specific themeing?  It looks like the patch in bug 424877 got rid of the famfamfam icons, up is being themed correctly since it is not hardcoded.  What I can't figure out is why the folders on OS X look right when windows doesn't differentiate.  Also if the folders on OS X are right, then the remote computer should be as well.

Comment 3

[Dão Gottwald [:dao]]

(In reply to comment #1)
> These aren't updated because of bug 388553. Need to update the hardcoded images
> at
> http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/netwerk/streamconv/converters/nsIndexedToHTML.cpp&rev=1.92#475
> .

The folder icons aren't hardcoded.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Actually I'm wrong, that bug is just about the favicon. We just need to add the appropriate style rules to toolkit/themes/winstripe/global/dirListing/dirListing.css (.dir, .symlink, etc.). Currently they are falling back to the default style hardcoded in the C++, which uses http://lxr.mozilla.org/seamonkey/source/layout/generic/folder.png .

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Talked to Alex on IRC - going to rename the local* images to be folder* images, since that's what they're for, and Alex is going to make new images to replace local/local-aero, and we'll update the hardcoded images with those (and also land the files themselves so that they're ready for when bug 388553 is fixed).

Comment 7

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: local-favicon.png

Talking to Gavin on irc, it turns out we have to use the same favicons for ftp:// and file:// across platforms.  We will use aero-remote for ftp:// on all platforms, and an aero style hard drive (attached) for file://

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 317975 [details] [diff] [review]
patch

CSS changes to correctly style the folder icons in ftp:/file: directory listings. Will patch the favicons separately.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Attachment: favicon changes

This patch:
1) overwrites the current local.png with attachment 317976 [details]
2) removes local-aero.png
3) replaces hardcoded icons in nsIndexedToHTML.cpp with data: URI versions of local.png and remote-aero.png

When bug 388553 is fixed, we should be able to just remove the hardcoded versions and uncomment the reference to chrome:// icons.

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Attachment: favicon changes (corrected)

Uploaded the wrong patch.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 317978 [details] [diff] [review]
favicon changes (corrected)

No-risk changes to icons to be consistent across platforms.

Comment 12

[:Gavin Sharp [email: [e-mail]]]

Attachment: combined patch

Comment 13

[Damon Sicore (:damons)]

Comment on attachment 318122 [details] [diff] [review]
combined patch

a1.9+=damons

Comment 14

[:Gavin Sharp [email: [e-mail]]]

mozilla/toolkit/themes/winstripe/global/jar.mn 	1.56
mozilla/toolkit/themes/winstripe/global/dirListing/dirListing.css 	1.7
mozilla/toolkit/themes/winstripe/global/dirListing/folder-aero.png 	1.1
mozilla/toolkit/themes/winstripe/global/dirListing/folder.png 	1.1
mozilla/toolkit/themes/winstripe/global/dirListing/local.png 	1.4
mozilla/toolkit/themes/winstripe/global/dirListing/local-aero.png 	 
mozilla/netwerk/streamconv/converters/nsIndexedToHTML.cpp 	1.93