Closed Bug 431061 Opened 12 years ago Closed 12 years ago

Migrate main Composer prefs and toolbars prefs to new pref pane

Categories

(SeaMonkey :: Composer, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0a1

People

(Reporter: stefanh, Assigned: stefanh)

References

Details

Attachments

(2 files, 2 obsolete files)

I have a patch that'll do the main Composer prefs and the toolbars prefs. Just need to test it a bit - atm bug 430858 makes it a bit difficult to do that :-/
Attached patch Migrate the prefs (obsolete) — Splinter Review
Attached patch Migrate the prefs (-w version) (obsolete) — Splinter Review
You've not changed the !DOCTYPE in the xul
OK, so I tested this a bit on an older build. I checked the toolbars prefs and they seem to work, also the Recent pages prefs (hmm, it always shows one page less than what the pref is set to?). Not really sure how to test the other main prefs, so I just verified that the pref value changed. This version has a correct doctype (thanks, Ian). Note here that we don't have a help section on the toolbars pane, but I'm thinking we might want to have one, so I haven't removed the reference.

Neil: I hope you don't mind that I re-indented the pref-toolbars.xul file a bit. (I can of course revert that if you want).
Attachment #318020 - Attachment is obsolete: true
Attachment #318021 - Attachment is obsolete: true
Attachment #318139 - Flags: superreview?(neil)
Attachment #318139 - Flags: review?(neil)
Comment on attachment 318139 [details] [diff] [review]
New version, now with correct doctype

>+        <textbox id="recentFiles"
>+                 name="recent string" 
>+                 size="3" 
>+                 value="10" 
>+                 preference="editor.history.url_maximum" 
>+                 oninput=" ValidateNumber(this, null, 0, 99); LimitStringLength('recentFiles',2);"/>
These days this ought to be a <textbox type="number"> but feel free to do that in a separate patch (or file a new bug and fix the rest of editor too!)
Attachment #318139 - Flags: superreview?(neil)
Attachment #318139 - Flags: superreview+
Attachment #318139 - Flags: review?(neil)
Attachment #318139 - Flags: review+
> These days this ought to be a <textbox type="number"> but feel free to do that
> in a separate patch (or file a new bug and fix the rest of editor too!)

Filed bug 432132 ;-)
 

Checking in editor/ui/composer.js;
/cvsroot/mozilla/editor/ui/composer.js,v  <--  composer.js
new revision: 3.40; previous revision: 3.39
done
Checking in editor/ui/jar.mn;
/cvsroot/mozilla/editor/ui/jar.mn,v  <--  jar.mn
new revision: 1.23; previous revision: 1.22
done
Checking in editor/ui/composer/content/ComposerCommands.js;
/cvsroot/mozilla/editor/ui/composer/content/ComposerCommands.js,v  <--  ComposerCommands.js
new revision: 1.207; previous revision: 1.206
done
Checking in editor/ui/composer/content/editorPrefsOverlay.xul;
/cvsroot/mozilla/editor/ui/composer/content/editorPrefsOverlay.xul,v  <--  editorPrefsOverlay.xul
new revision: 1.15; previous revision: 1.14
done
Checking in editor/ui/composer/content/pref-composer.xul;
/cvsroot/mozilla/editor/ui/composer/content/pref-composer.xul,v  <--  pref-composer.xul
new revision: 1.36; previous revision: 1.35
done
Checking in editor/ui/composer/content/pref-toolbars.xul;
/cvsroot/mozilla/editor/ui/composer/content/pref-toolbars.xul,v  <--  pref-toolbars.xul
new revision: 1.5; previous revision: 1.4
done
Target Milestone: --- → seamonkey2.0alpha
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.