431081 - Native selection box contents missing in Firefox 3 - Vista only?

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect)

Description

[Recall]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008042705 Firefox
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008042705 Firefox

Browse to the supplied url and the selection boxes are missing, the arrow is there but the words such as "product type" are missing.

Reproducible: Always

Steps to Reproduce:
1. Navigate to http://www.logitech.com/index.cfm/support_downloads/downloads/


Actual Results:  
Selection box contents are missing

Expected Results:  
Selection contents should not be missing.

I think this might be a vista specific issue based on feedback from this thread http://forums.mozillazine.org/viewtopic.php?t=651734

Comment 1

[Recall]

Attachment: Comparison screenshot between IE7 and FF3

Comment 2

[Antti Tervasmäki]

I can confirm, those selection boxes are not visible, though they seem to be there by right clicking in them, a little confusing....
Vista Ultimate 64bit

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008042705 Minefield/3.0pre Firefox/3.0 ID:2008042705

Comment 3

[Recall]

Ok, got a regression range:

Works:

http://hourly-archive.localgho.st/win32/20080425_1432_firefox-3.0pre.en-US.win32.zip

Fails:

http://hourly-archive.localgho.st/win32/20080425_1624_firefox-3.0pre.en-US.win32.zip

So must be bug 427122.

I have set a dependency on this and request blocking FF3.

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Well, ok; I don't know what to do here.  For the controls to be drawn correctly, they need padding.  Because our native theme system is a little broken, it can only ever override padding -- it can't adjust author specified padding.  The patch in bug 427122 doesn't muck with padding if the author has specified it; on that page, there is explicit padding of 0px.

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: don't draw background-coloured line in PaintFocus

Ok, so this is the PaintFocus problem again.  What's happening is that if there's no padding, the focus rectangle painted by nsComboboxControlFrame::PaintFocus is being painted directly over the combobox border.  I tried to get rid of this in another patch, but I think we'll need to actually do it... reftests all pass, is there any possible reason for this to actually be here?  Elements should already have the background color painted/element repainted if focus goes away, so it's not that...

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 318237 [details] [diff] [review]
don't draw background-coloured line in PaintFocus

The code was added in bug 32920 to "erase" the focus rect. I think that's entirely bogus; when the frame loses focus it will be repainted and the focus rect will go away on its own.

Having said that, given the stage of the release, please test all combinations of disabled/focused comboboxes on all 3 platforms plus classic and Luna on XP, if you can.

Comment 7

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 318237 [details] [diff] [review]
don't draw background-coloured line in PaintFocus

Tested on all 3 platforms -- turns out that Cocoa and Gtk2 don't use this code at all, their native theme impls draw focus rectangles for dropdowns natively.

With an explicitly set background (so we get xpwidgets), things look the same, except for "background: transparent" -- without this patch, there's a white border when the widget is unfocused, and it goes away correctly.  So I think this is good to go.

Comment 8

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: my testcase

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 318237 [details] [diff] [review]
don't draw background-coloured line in PaintFocus

a1.9=beltzner

Comment 10

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Checking in layout/forms/nsComboboxControlFrame.cpp;
/cvsroot/mozilla/layout/forms/nsComboboxControlFrame.cpp,v  <--  nsComboboxControlFrame.cpp
new revision: 1.431; previous revision: 1.430
done

Comment 11

[Marcia Knous [:marcia]]

verified fixed using  Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008042906 Minefield/3.0pre.