431127 - Move email-specific itip processor code to the transport

Status: RESOLVED FIXED

(Calendar :: E-mail based Scheduling (iTIP/iMIP), defect)

Description

[Philipp Kewisch [:Fallen][☁️📆]]

(Followup from bug 428392)

We have some locations where transport specific things happen. For example:

>Index: calendar/base/src/calItipProcessor.js
>+        // TODO This is email specific -> Move to transport
>         // When replying, the reply must only contain the ORGANIZER and the
>         // status of the ATTENDEE that represents ourselves. Therefore we must
>         // remove all other ATTENDEEs from the itipItem we send back.
>         if (respMethod == "REPLY") {
>             // Get the id that represents me.
>             // XXX Note that this doesn't take into consideration invitations
>             //     sent to email aliases. (ex: lilmatt vs mwillis)
>-            var me;
>-            var idPrefix;
>-            if (transport.type == "email") {
>-                me = transport.defaultIdentity;
>-                idPrefix = "mailto:";
>-            } else {
>-                throw Components.results.NS_ERROR_NOT_IMPLEMENTED;
>-            }
> 
>             var attendees = newItem.getAttendees({});
> 
>             for each (var attendee in attendees) {
>                 // Leave the ORGANIZER alone.
>                 if (!attendee.isOrganizer) {
>                     // example: mailto:[e-mail]
...


Some work was already done, getting the scheme from the transport for example. If it turns out to be impractical to automatically insert a ":" between |transport.scheme| and the attendee address, then this could be changed to.

Comment 1

[Daniel Boelzle [:dbo]]

I think this is finally fixed with bug 457203.

Comment 2

[Philipp Kewisch [:Fallen][☁️📆]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".