431218 - multiple install: targets missing in calendar/ tree in sunbird 0.8

Status: RESOLVED FIXED

(Calendar :: Build Config, defect)

Description

[Alexander Sack]

noticed while preparing sunbird/lightning 0.8 package that a bunch of files were missing after make install in the $(mozappdir)/js/ directory.

For now I searched the hierachy Makefile.in files with EXTRA_SCRIPTS that don't have a install::.*$(EXTRA_SCRIPTS) line:

mozilla/calendar/providers/base/Makefile.in
mozilla/calendar/providers/caldav/Makefile.in
mozilla/calendar/providers/ics/Makefile.in
mozilla/calendar/providers/memory/Makefile.in
mozilla/calendar/providers/storage/Makefile.in

Comment 1

[Alexander Sack]

Attachment: add install:: target

Fix:

mozilla/calendar/providers/base/Makefile.in
mozilla/calendar/providers/caldav/Makefile.in
mozilla/calendar/providers/ics/Makefile.in
mozilla/calendar/providers/memory/Makefile.in
mozilla/calendar/providers/storage/Makefile.in

Comment 2

[Philipp Kewisch [:Fallen][☁️📆]]

Alexander, I'm not 100% sure, but I remember someone telling me that the install target is deprecated/not really used. I believe I did that on purpose when changing the provider Makefiles.

I'll make sure thats correct though before reviewing.

Comment 3

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 318223 [details] [diff] [review]
add install:: target

Looks good, r=philipp

Comment 4

[Philipp Kewisch [:Fallen][☁️📆]]

Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED

Comment 5

[(not currently active) Ted Mielczarek]

|make install|, at least for Firefox/XULRunner, is implemented in toolkit/mozapps/packager.mk. It basically just does the |package| steps, then unpacks that package to the proper place.
http://lxr.mozilla.org/mozilla/source/toolkit/mozapps/installer/packager.mk#412