431231 - Unable to save RSS feed to anything but the bookmarks toolbar (UI missing?)

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Marcia Knous [:marcia]]

Seen using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008042806 Minefield/3.0pre. Also seen on Windows.

STR:
1. Visit a site with an RSS feed, such as nytimes.com
2. Select the RSS icon
3. Select the "Subscribe Now" button

Expected: I should be able to save to Bookmarks Menu or some other location in places.

Actual: Only the name field is present, and the RSS feed defaults to saving on the Bookmarks Toolbar.

I think the "Create in" UI is somehow missing. That UI is present in the build from the 27th.

Comment 1

[Marcia Knous [:marcia]]

Regression Window:  Works using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9pre) Gecko/2008042704 Minefield/3.0pre.

Broken:  Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9pre) Gecko/2008042806 Minefield/3.0pre

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Marco, could this be a regression from your patch on bug 428403?

All check-ins within this regression window: http://tinyurl.com/67w5ge

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #2)
> Marco, could this be a regression from your patch on bug 428403?

Once again and CC'ing Marco...

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #3)
> (In reply to comment #2)
> > Marco, could this be a regression from your patch on bug 428403?

... but it doesn't explain the missing UI. 

Comment 5

[Marco Bonardo [:mak]]

no, the regression is from bug 425851

Comment 6

[Marco Bonardo [:mak]]

Attachment: patch

show always the folder picker when we are not in edit mode

Comment 7

[Asaf Romano (gone)]

Comment on attachment 318340 [details] [diff] [review]
patch

r=mano.

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 318340 [details] [diff] [review]
patch

a1.9=beltzner

Comment 9

[Dietrich Ayala (:dietrich)]

Checking in browser/components/places/content/bookmarkProperties.js;
/cvsroot/mozilla/browser/components/places/content/bookmarkProperties.js,v  <--  bookmarkProperties.js
new revision: 1.87; previous revision: 1.86
done

Comment 11

[Carsten Book [:Tomcat]]

verified fixed using Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9pre) Gecko/2008043007 Minefield/3.0pre ID:2008043007 and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre)
Gecko/2008043013 Firefox/3.0pre

Comment 12

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv