431236 - Treehydra: Segfaults in attempt to access 'u5' union member(inner functions should be called eagerly)

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[David Mandelin [:dmandelin]]

Apparently this is caused by generated code in lazy_lang_decl storing pointers to GCC inline functions on the heap, which then get called later in ResolveTreeNode, when they are invalid.

Comment 1

[David Mandelin [:dmandelin]]

Not that I have any strong opinions on this, but I was thinking "not using nested functions" was a reasonable alternate solution. :-)

Comment 2

[(dormant account)]

It's reasonable, but it's much easier with nested functions. If one starts inlining what's currently nested functions then convert_tree gets a lot more complicated. I tried that approach and it was messy, the generated code looked uglier and I couldn't bother to rewriting large parts of convert_tree js once I realized how much simpler nested functions are.

Personally, I think nested functions should be part of the C/C++ standards, as they allow for much more concise code.

Comment 3

[David Mandelin [:dmandelin]]

Attachment: Test case treehydra script

Comment 4

[David Mandelin [:dmandelin]]

Attachment: Test case C++ file

Comment 5

[Vlad Sukhoy]

Happens on mac too.

Comment 6

[(dormant account)]

pushed fix