Closed
Bug 431241
Opened 16 years ago
Closed 16 years ago
Use a solid line between results in the error console
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 3
People
(Reporter: faaborg, Assigned: ehsan.akhgari)
Details
Attachments
(1 file)
809 bytes,
patch
|
Gavin
:
review+
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
As a follow up to bug 431229 (in that i just noticed looking at https://bugzilla.mozilla.org/attachment.cgi?id=318250), we should use a solid ThreeDLightShadow line in the error console, similar to the awesome bar and the download manager. This is for both XP and Vista.
Assignee | ||
Updated•16 years ago
|
Assignee: nobody → ehsan.akhgari
Assignee | ||
Updated•16 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Updated•16 years ago
|
Assignee: ehsan.akhgari → nobody
Status: ASSIGNED → NEW
Component: Tabbed Browser → Theme
QA Contact: tabbed.browser → theme
Assignee | ||
Updated•16 years ago
|
Assignee: nobody → ehsan.akhgari
Assignee | ||
Updated•16 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•16 years ago
|
||
As simple as it gets!
Attachment #318273 -
Flags: review?(gavin.sharp)
Not that I have any preference either way, but what's wrong w/ dotted lines? :P
Updated•16 years ago
|
Attachment #318273 -
Flags: review?(gavin.sharp) → review+
Comment 3•16 years ago
|
||
(In reply to comment #2) > Not that I have any preference either way, but what's wrong w/ dotted lines? :P > perhaps looks more 'native'? :P
While we're on the topic, I've been scanning through old bugs, and I noticed this one that had fallen off the radar: bug 424043. Not sure what I think about what the bug suggests doing, but I thought that I'd mention it. (In reply to comment #3) > perhaps looks more 'native'? :P > Hehe.
Reporter | ||
Comment 5•16 years ago
|
||
>and I noticed this one that had fallen off the radar: bug 424043. yeah that one fell off my radar as well >what's wrong w/ dotted lines? :P what isn't wrong with dotted lines :p
Assignee | ||
Comment 6•16 years ago
|
||
Comment on attachment 318273 [details] [diff] [review] Patch (v1) Requesting approval for this minimal change to make the Error Console window look more native on Windows.
Attachment #318273 -
Flags: approval1.9?
Assignee | ||
Updated•16 years ago
|
Whiteboard: [has patch][has review][needs approval]
Comment 7•16 years ago
|
||
Comment on attachment 318273 [details] [diff] [review] Patch (v1) a=beltzner, holding his nose a little ...
Attachment #318273 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Updated•16 years ago
|
Keywords: checkin-needed
Whiteboard: [has patch][has review][needs approval] → [has patch][has review][has approval]
Comment 8•16 years ago
|
||
mozilla/toolkit/themes/winstripe/global/console/console.css 1.12
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [has patch][has review][has approval]
Target Milestone: --- → Firefox 3
You need to log in
before you can comment on or make changes to this bug.
Description
•