431452 - Classic theme stop button states are mixed up

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Victor Bielawski]

Attachment: patch

In the SeaMonkey Classic theme, the stop button's states are mixed up: the active state is shown on hover and the hover state is shown on active. This happens since the landing of the new Classic theme.

Comment 1

[Stefan [:stefanh]]

What are the coordinates for other icons in chrome://communicator/skin/icons/communicatoricons.png? If the problem is that the button is in the wrong place, would it be better to just swap the hover and active icons?

Comment 2

[Stefan [:stefanh]]

http://lxr.mozilla.org/seamonkey/source/suite/themes/classic/communicator/icons/communicatoricons.png

Comment 3

[Robert Kaiser]

yes, the graphics are in the wrong place in the PNG, it should be fixed there. CCing Manuel, who created this image. Perhaps he can fix it in the same turn that he fixes the problem we have on Mac with hover and normal icons not staying in the same place even though CSS is correct (icon anti-alising position differs slightly).

Comment 4

[Stefan [:stefanh]]

Attachment: Fix icon(s)

I flipped the icons and then I ran "pngcrush -rem cHRM -rem iCCP" on them. That decreased the size with around 10%. That said, it looks like my OS still thinks the icons has the same color profile as before ("Calibrated RGB Colorspace"). I don't have pngcheck, so I can't really say if the profile chunks are gone or not.

Comment 5

[Stefan [:stefanh]]

Comment on attachment 343930 [details] [diff] [review]
Fix icon(s)

KaiRo, see previous comment.

Comment 6

[Stefan [:stefanh]]

Comment on attachment 343930 [details] [diff] [review]
Fix icon(s)

Hmm, I guess I could remove the sRGB chunks as well

Comment 7

[Stefan [:stefanh]]

Comment on attachment 343930 [details] [diff] [review]
Fix icon(s)

Actually, not I single byte in change, so I guess the images didn't had any sRGB chunks.

Comment 8

[Stefan [:stefanh]]

Attachment: communicatoricons-small.png

Here's the new communicator-icons-small.png in the above patch

Comment 9

[Stefan [:stefanh]]

Attachment: and communicatoricons.png...

Comment 10

[Robert Kaiser]

Comment on attachment 343930 [details] [diff] [review]
Fix icon(s)

r=me based on the icons attached below.

Comment 11

[Stefan [:stefanh]]

Pushed 675:c42ed76e1815.