431453 - Make browser mochitests pass on SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Robert Kaiser]

We currently have a number of failing browser mochitests on SeaMonkey, for the following reasons:

FUEL is Firefox-only:
chrome://mochikit/content/browser/docshell/test/browser/browser_bug134911.js
chrome://mochikit/content/browser/docshell/test/browser/browser_bug92473.js

PageProxySetIcon() function is Firefox-only:
chrome://mochikit/content/browser/extensions/cookie/test/browser_test_favicon.js

history.addPageWithDetails is not defined in xpfe history:
chrome://mochikit/content/browser/suite/modules/test/browser_sanitizer.js

SeaMonkey doesn't use toolkit download manager:
chrome://mochikit/content/browser/toolkit/mozapps/downloads/tests/browser/* (14 failures on Linux, 13 on Windows)

Unknown:
FAIL - Cookie test setup successfully - chrome://mochikit/content/browser/suite/modules/test/browser_sanitizer.js


We should find out some way to make SeaMonkey not fail those tests. This might mean making some files not copied to tests on other apps than Firefox or manipulating how tests perform thing so that SeaMonkey can pass them, or even fix SeaMonkey to pass those tests.

Comment 1

[Justin Wood (:Callek)]

the toolkit download manager stuff will still (likely) fail if we use our own UI for the download manager (including progress dialogs).

Solution would be for us to write our own tests mimicking the functionality tested in those toolkit ones, (and disabling those toolkit/ ones somehow of course).

Comment 2

[Robert Kaiser]

Attachment: patch: make a few tests FF-only or non-SM, fix sanitizer tests

This patch makes the tests that use Firefox-only features be installed for Firefox only, the download manager tests to be excluded for SeaMonkey just like the source (currently, we can figure out details when we switch to the toolkit dlmgr) and fixes the sanitizer tests.

Neil, can you r/sr the sanitizer changes?
The first change there is to make us accept 3rd-party cookies for the cookie test, so setting them works.
The second change is the only solution I could find to make the history test work with xpfe history: remove all cookies and just check the count once we have set one. When the more advanced interfaces of toolkit are found, we use them instead.

smontagu, can you please r making the docshell tests you added Firefox-only?

I'll add additional reviewers for cookie and downloads in a minute.

Comment 3

[Robert Kaiser]

Comment on attachment 318695 [details] [diff] [review]
patch: make a few tests FF-only or non-SM, fix sanitizer tests

dwitte, can you review making the favicon cookie test Firefox-only?

Comment 4

[Robert Kaiser]

Comment on attachment 318695 [details] [diff] [review]
patch: make a few tests FF-only or non-SM, fix sanitizer tests

gavin, can you please review excluding the dlmgr tests for SeaMonkey as well for now?

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 318695 [details] [diff] [review]
patch: make a few tests FF-only or non-SM, fix sanitizer tests

r=me on the toolkit/mozapps/downloads/Makefile.in
 change.

Comment 6

[[e-mail]]

Comment on attachment 318695 [details] [diff] [review]
patch: make a few tests FF-only or non-SM, fix sanitizer tests

>Index: mozilla/extensions/cookie/test/Makefile.in
>===================================================================
>+# see above, only defined for Fireofx

r=me provided you spell Firefox right ;)

Comment 7

[Simon Montagu :smontagu]

Comment on attachment 318695 [details] [diff] [review]
patch: make a few tests FF-only or non-SM, fix sanitizer tests

r=me on docshell/test/browser/Makefile.in

Comment 8

[Robert Kaiser]

Comment on attachment 318695 [details] [diff] [review]
patch: make a few tests FF-only or non-SM, fix sanitizer tests

requesting a1.9 - all this does is exclude some tests from being installed in non-Firefox or in SeaMonkey builds (apart from the suite/ part that fixes tests but is NPOTB for FF).

Comment 9

[Damon Sicore (:damons)]

Comment on attachment 318695 [details] [diff] [review]
patch: make a few tests FF-only or non-SM, fix sanitizer tests

a1.9+=damons

Comment 10

[Robert Kaiser]

Checked in, thanks everybody!