431514 - should indicate frames for which we don't have symbol information

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[(not currently active) Ted Mielczarek]

Sometimes in stack traces you wind up with just offsets into a module, but you have no way of knowing if this is because we didn't have symbols for that module, or because the address just isn't in a known function in that module. It'd be nice to indicate somehow that we didn't have symbols for a particular stack frame to make this clearer.

Comment 1

[timeless]

it'd also be nice if we showed that for the "all modules" section too.

Comment 2

[(not currently active) Ted Mielczarek]

The complicating factor here might be if we care to be very accurate. We may not have had symbols at the time we processed that crash, but we might wind up with them later. If we simply go by what's on disk, it might be misleading to show that we have symbols for a module that we didn't during processing.

Comment 3

[Laura Thomson :laura]

Still useful? 

Detection is: in the pipe dump if third field is filled and fourth one empty.  BUT, let's wait and block this on JSON MDSW

Comment 4

[(not currently active) Ted Mielczarek]

Yeah. We actually can explicitly get this info out, we can list modules which we wanted symbols for but didn't get them, as well as modules for which we tried to load symbols but failed (if they were corrupt somehow). Reporting it should be pretty trivial then.

Comment 5

[(not currently active) Ted Mielczarek]

Attachment: indicate frames with missing symbols

This change adds a "missing_symbols": true key to frame and module objects that tried to load symbols but didn't find them. It also adds a "corrupt_symbols": true to them if they found symbols but failed to load them for some reason.

Comment 6

[(not currently active) Ted Mielczarek]

Attachment: Example output

Here's some example output.

Comment 7

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/57226965dac95fb0cc43a63881a5584e2fce4755
bug 431514 - indicate frames with missing symbols

https://github.com/mozilla/socorro/commit/cd3767a4feeeed9e44fc7b29d175d8d0e45b0169
Merge pull request #1607 from luser/symbol-status

bug 431514 - indicate frames with missing symbols