431587 - Print selection uses wrong "total number of pages" when printing scaled output

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: testcase 1

Steps to reproduce:
 1. Load testcase 1
 2. Select-All
 3. Print, with "print selection" ticked
 4. Examine output

EXPECTED RESULTS:
 3 pages, numbered "1 of 3", "2 of 3", and "3 of 3"
 
ACTUAL RESULTS:
 3 pages, numbered "1 of 5", "2 of 5", and "3 of 5"

It looks like we're not scaling down correctly when calculating the total expected number of pages.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: trivial patch

As this comment in the patched region suggests...
-                // XXXdholbert does this num-pages calculation need to take
-                // aPO->mZoomRatio into consideration?
... the num-pages calculation does indeed need to take the zoom ratio into consideration.

This fixes the bug.

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 318694 [details] [diff] [review]
trivial patch

Requesting approval.
 - Very low-risk
 - one-line patch
 - clearly what we should be doing

Comment 3

[Damon Sicore (:damons)]

Comment on attachment 318694 [details] [diff] [review]
trivial patch

a1.9+=damons

Comment 4

[Daniel Holbert [:dholbert]]

Patch checked in.

Checking in layout/printing/nsPrintEngine.cpp;
/cvsroot/mozilla/layout/printing/nsPrintEngine.cpp,v  <--  nsPrintEngine.cpp
new revision: 1.183; previous revision: 1.182
done

Comment 5

[Marcia Knous [:marcia]]

https://litmus.mozilla.org/show_test.cgi?id=5324 added to Litmus.