431684 - Have navigator/tabbrowser "close" menu items have separate accesskeys

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Robert Kaiser]

updateCloseItems() in navigator.js updates the File > Close menu item label with different texts for tabbed and untabbed windows, depending on tabbrowser status. For L10n purposes, we should pair setting this label with also setting the accesskey, because we can't guarantee that the global "close" accesskey from platformCommunicatorOverlay fits with both navigator.properties labels in all languages, and even less for localizers to know that an accesskey from there applies to the strings here.
To play nice with L10n tools (pairing labels with accesskeys), it might be good to change the ID for the labels to end in .label at the same time.

Comment 1

[Robert Kaiser]

Attachment: patch: pair labels with accesskeys

Here's a patch to pair labels with accesskeys as described in comment #0, using the same accesskey for en-US as currently defined in platformCommunicatorOverlay (which continues to be used with the string from there in non-browser windows).

Comment 2

[Robert Kaiser]

Checked in, thanks.