431770 - [FIX]###!!! ASSERTION: Should be in an update while creating frames: 'mUpdateCount != 0'

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Carsten Book [:Tomcat]]

Attachment: stack

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008050123 Firefox/3.0pre

-> 3 tabs open, focus is on apple.com
-> Open the Add-on Manager -> Plugins
-> Disable the Shockwave Flash Plugin
--> Assertion

###!!! ASSERTION: Should be in an update while creating frames: 'mUpdateCount != 0', file /debug/mozilla/layout/base/nsCSSFrameConstructor.cpp, line 6777

Comment 1

[Boris Zbarsky [:bzbarsky]]

This worksforme with the steps from comment 0, for what it's worth.

I have no idea how that stack was generated, but it has nothing to do with reality...  Those functions simply do not call each other.

Comment 2

[Carsten Book [:Tomcat]]

> I have no idea how that stack was generated, but it has nothing to do with
> reality...  Those functions simply do not call each other.
> 

yeah i think i need here fix-macosx-stack.pl too :)

Comment 3

[Carsten Book [:Tomcat]]

(In reply to comment #1)
> This worksforme with the steps from comment 0, for what it's worth.

Yeah seems a better way to reproduce is to load http://www.spiegel.de
when you disable then the plugin, you get lots of this assertion

Comment 4

[Boris Zbarsky [:bzbarsky]]

That worksforme too.  Perhaps this is a regression; my tree is as of Apr 28.  I'll try pulling an updated one, I guess..

Comment 5

[Boris Zbarsky [:bzbarsky]]

I assume you either don't have any extensions or hit this in safe mode?

Comment 6

[Carsten Book [:Tomcat]]

Attachment: new complete Stack

Hi BZ, i attached a new (better) stack from my new Win XP Debug Build.

This Assertion happen also with a new Profile (no Extensions) and latest Flash Plugin. A maybe better way to reproduce (it could be that the spiegel.de site is different when you surf to this site with a nnon-german IP):

Go to www.adobe.com (just the Frontpage with the Flash Content) -> Disable the Flash Plugin in the Extension Manager -> Assertion

Running the Debug Build with export XPCOM_DEBUG_BREAK=stack caused btw a kind of hang because i got into a kind of Assertion loop :)

Comment 7

[Boris Zbarsky [:bzbarsky]]

Yeah, that makes a lot of sense!  PresShell::ReconstructFrames should be doing an update batch in the frame constructor, I think.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Attachment: Like so

Comment 9

[Carsten Book [:Tomcat]]

(In reply to comment #8)
> Created an attachment (id=321551) [details]
> Like so
> 

this patch fix the problem in my debug build :) 

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 321551 [details] [diff] [review]
Like so

r+sr=dbaron, but there goes my promise to make people write exception-safe code since everybody seems to think we should use C++ exceptions...

Comment 11

[Boris Zbarsky [:bzbarsky]]

We could set up a helper class for that, sure.

Comment 12

[Boris Zbarsky [:bzbarsky]]

Fixed.