431829 - Moving Today Pane button on Task toolbar removes it from Calendar toolbar and duplicates it on the Task toolbar

Status: VERIFIED FIXED

(Calendar :: Lightning Only, defect)

Description

[Stefan Sitter [:ssitter]]

Lightning 0.9pre (2008050120) + 2.0.0.15pre (2008050104)

Moving Today Pane button on Task toolbar removes it from Calendar toolbar and duplicates it on the Task toolbar.

Steps to Reproduce:
1. Start Thunderbird with clean profile, install Lightning and restart.
2. Switch to Calendar Mode and note position of the Today Pane toolbar button
3. Switch to Task Mode and note position of the Today Pane toolbar button
4. Right click Task toolbar and select Customize...
5. Drag and drop the Today Pane button to a different position on the toolbar
6. Repeat step 2. and 3.

Actual Results:
Today Pane button is shown twice on the Task toolbar. Once at the old position and once at the new position. Today Pane button has disappeared from the Calendar toolbar.

Expected Results:
Today Pane button is shown once on the Task toolbar at the new position.
Today Pane button is still shown on the Calendar toolbar.

Comment 1

[Stefan Sitter [:ssitter]]

Attachment: use the correct task toolbar button

Looks like a copy and paste error. Bug 389150 added a new toolbar button with id "task-show-todaypane-button". But the task toolbar still lists "calendar-show-todaypane-button" in the default set (like the calendar toolbar).

Comment 2

[Berend Cornelius]

Comment on attachment 319179 [details] [diff] [review]
use the correct task toolbar button

patch works fine. Thank your for your effort!

Comment 3

[Simon Paquet [:sipaq]]

Berend, please let the release drivers decide on wanted-status. I see no need for it here, since the patch will surely get in within the next few days.

Comment 4

[Simon Paquet [:sipaq]]

BTW Stefan, you should really apply for checkin rights. According to Bugzilla you've fixed more bugs than any of the current calendar devs. So please file a bug for getting CVS access and CC Daniel and me on it, so that we can vouch for you.

Comment 5

[Berend Cornelius]

patch checked in on trunk and MOZILLA_1_8_BRANCH.

->FIXED

Comment 6

[Andreas Treumann]

Checked in nightly build 2008050518 -> VERIFIED.