Closed
Bug 431857
Opened 17 years ago
Closed 17 years ago
Allow overriding of inferred outparam
Categories
(Developer Infrastructure :: Source Code Analysis, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: benjamin, Assigned: dmandelin)
References
Details
Attachments
(1 file, 1 obsolete file)
|
5.35 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
nsStringEnumerator.cpp has a signature
StringEnumeratorTail(T** aResult)
which isn't an outparam.
The attached patch marks that argument as an inparam, but I need the outparam analysis to check for the annotation.
> +# define NS_INPARAM __attribute__((user("NS_intparam")))
Typo? 'NS_intparam' -> 'NS_inparam'
|
Assignee | |
Comment 2•17 years ago
|
||
Includes the annotation patch, with the typo fixed. Passes a new test case and the file ref'd in the bug report.
Attachment #319016 -
Attachment is obsolete: true
Attachment #319094 -
Flags: review?
|
|
Assignee | |
Updated•17 years ago
|
Attachment #319094 -
Flags: review? → review?(benjamin)
|
Reporter | |
Updated•17 years ago
|
Attachment #319094 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Updated•17 years ago
|
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
|
|
||
Updated•3 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•