Closed
Bug 43195
Opened 25 years ago
Closed 25 years ago
Cookies pref-panel getting clipped on right side if image blocking pref is on
Categories
(SeaMonkey :: Preferences, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: morse, Assigned: eric)
References
Details
(Keywords: regression)
Attachments
(1 file)
Go to prefs panel and open the advanced/cookies subpanel
It contains two rectangles, one for cookies and one for images (commercial build
contains only the cookies rectangle)
These rectangles are getting clipped on the right side.
(Note: this bug has been broken out of 43126 as requested)
|
Reporter | |
Updated•25 years ago
|
Keywords: regression
|
||
Comment 1•25 years ago
|
||
h'm, jrgm and i don't see this using 2000.06.20.08 optimized commercial bits on
winnt, linux or mac.
Status: NEW → RESOLVED
Closed: 25 years ago
Component: XP Apps → Preferences
Resolution: --- → WORKSFORME
|
|
Reporter | |
Comment 2•25 years ago
|
||
This is still happening for me with a tree that I pulled and build just a couple
of hours ago. It's a debug mozilla build running on winnt.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
|
||
Comment 3•25 years ago
|
||
Okay, I see it in the mozilla build (probably due to differences in enablement
of image blocking prefs :-/).
Here's what's happening. The panel is a <titledbox> with a series of <checkbox>
followed at the end by <html> for some text. During the onload handler, the
first <checkbox> is (possibly) set to "hidden", depending on the value of a
pref 'imageblocker.enabled'.
When that <checkbox> is hidden, this "pulls up" the content that follows, but
the content from the last part of the original dimensions of the <titledbox>
is not repainted (leaving the "double line" -- two images of the same text).
Onwards to the master of all things <box>, <titledbox>, and <html> : evaughan.
Assignee: ben → evaughan
Status: REOPENED → NEW
|
|
Reporter | |
Comment 4•25 years ago
|
||
Your comment above is a little confusing. You talk about double line of text
but this bug report talks about right-side clipping. I think you meant that
comment for bug 43209.
But your reasoning appears to be correct. It's the lack of image-blocking in
the commercial build that was causing this panel to not get its right side
clipped there. I just demonstrated that by turning off imageblocking in my
prefs.js file for my mozilla build and the clipping reported here no longer
occurred. Also, the double-image reported in bug 43209 no longer occured. So
there is a correlation between enabling image-blocking and these two bugs.
|
|
||
Comment 5•25 years ago
|
||
Doh! My comment above applies _only_ to bug 43209. I commented on the
wrong bug.
However, yes, these bugs only show in the mozilla build due to different image
blocking default prefs, but the different prefs are the catalyst, not the
root cause.
|
|
||
Comment 6•25 years ago
|
||
Anyways, this one boils down to : <html> contained inside a horizontal <box>
is not doing line-breaking. That then limits the min-width of the entire
pref panel, leading to the clipping on the right hand side. I have a simple
testcase that I will attach.
|
|
||
Comment 7•25 years ago
|
||
|
|
||
Comment 8•25 years ago
|
||
thanks, i see it now! modified summary.
Summary: Cookies pref-panel getting clipped on right side → Cookies pref-panel getting clipped on right side if image blocking pref is on
|
|
Reporter | |
Comment 9•25 years ago
|
||
Fix checked in. Changed file is pref-cookies.xul and pref-cookies.dtd
Status: NEW → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
|
|
||
Comment 10•25 years ago
|
||
looks fine now. vrfy 2000.07.17.08 comm on linux and winnt, moz on mac.
Status: RESOLVED → VERIFIED
|
||
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•