Closed Bug 431980 Opened 15 years ago Closed 15 years ago

Tasks marked as completed disappear from tasks list in task mode

Categories

(Calendar :: Tasks, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: bv1578, Assigned: giermann)

References

Details

(Keywords: regression)

Attachments

(1 file)

1.22 KB, patch
berend.cornelius09
: review+
Details | Diff | Splinter Review
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; it; rv:1.8.1.14) Gecko/20080404 Firefox/2.0.0.14
Build Identifier: Lightning 0.9pre (build 2008042518);  Thunderbird 2.0.0.12 (build 20080213)

When in task mode, a task can be marked as completed by selecting "Mark completed" from Task menu, selecting "100% completed" from drop down list icon on toolbar, flagging the checkbox from column "done" in the list and selecting "Mark completed" or "progress 100%" from context menu. 
If you try to mark as completed a selected task from the list when you are in task mode  with any one of this methods, the task disappear.

In particular a task disappear from the list pressing (without release) mouse button (right or left) on checkbox in "done" column.

Radio button selected on task filter is irrilevant.
Error console reports no error.

Tasks vanished are still in storage.sdb file (no data loss), you can see them, correclty marked as completed, if you install a previous version (I tried with Lightning 0.9pre build 2008042020).

Reproducible: Always

Steps to Reproduce:
1.create a new profile
2.in task mode create a new task and select it
3.mark it as completed (with menu item, icon on toolbar, context menu, "done" checkbox)
Actual Results:  
Task disappear from the list.

Expected Results:  
Task should be in the list marked as completed (% Complete = 100).

Lightning 0.9pre build 2008042020 worked correctly.
I can confirm this failure. Completed tasks will not be displayed in Task Mode althought the task filter is set to 'All' or 'Completed Tasks'.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
Regression range:
    Works in Ltn 0.9pre (2008042318) + Tb 2.0.0.15pre (20080501).
    Fails in Ltn 0.9pre (2008042418) + Tb 2.0.0.15pre (20080501).

Checkins during regressin range: http://tinyurl.com/5prlzg 
Regressed by Bug 386596.
Blocks: 386596
Occurs also on Linux and Solaris.
Flags: wanted-calendar0.9?
OS: Windows XP → All
Hardware: PC → All
Flags: wanted-calendar0.9? → wanted-calendar0.9+
Flags: blocking-calendar0.9?
Flags: wanted-calendar0.9+
Flags: blocking-calendar0.9?
Flags: blocking-calendar0.9+
Attached patch patch v1Splinter Review
This was simple: Berend inverted the name and logic of a property without changing the default value - fixed with this.
Attachment #322742 - Flags: review?(Berend.Cornelius)
Comment on attachment 322742 [details] [diff] [review]
patch v1

r=berend. This bug regressed from bug 386596 "Option to show completed Tasks should be moved to the menu" that I admittedly reviewed. Thank you for resolving that.
Attachment #322742 - Flags: review?(Berend.Cornelius) → review+
Assignee: nobody → giermann
Status: NEW → ASSIGNED
Patch was checked in by Berend on Trunk and MOZILLA_1_8_BRANCH
-> FIXED? Or is there anything else required?
Bug is fixed...
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Checked in lightning 2008052818 -> VERIFIED.
Status: RESOLVED → VERIFIED
Target Milestone: --- → 0.9
You need to log in before you can comment on or make changes to this bug.