43202 - fix MozillaBuildList.pm to use mozilla/profile/defaults/MANIFEST

Status: RESOLVED FIXED

(SeaMonkey :: General, defect, P3)

Description

[(not reading, please use [e-mail] instead)]

look for "Default _profile_ directory stuff" in NGLayoutBuildList.pm

instead of using mozilla/profile/defaults/MANIFEST to copy the contents of
mozilla/profile/defaults to the default profile dir (and the en-US subdirectory)
we have _copy() commands for each file.


assigning to mac build guru sfraser.

(this isn't a high priority item, and I know you are overloaded, so no rush.)

Comment 1

[rubydoo123]

setting to m18

Comment 2

[Simon Fraser [no longer active]]

M20 build issue.

Comment 3

[rubydoo123]

reassigning build bugs to build & release team, this one goes to jj

Comment 4

[Simon Fraser [no longer active]]

This bug probably still applies to the new build scripts.

Comment 5

[tao]

Simon probably is the proper owner of this since he is revamping the build script.

Comment 6

[Simon Fraser [no longer active]]

Build script revamping is done. I'm passing off ownership of the build scripts
to JJ.

Comment 7

[J.J. Enser]

accepting. will submit a patch to the build script.

Comment 8

[J.J. Enser]

attaching patch to mozilla/build/mac/build_scripts/MozillaBuildList.pm
this patch will create aliases into of the desired files into dist intead of 
copying them. If this is not ok, let me know and I'll fix he patch.

successfully tested optimized build scripts with this patch --BuildResources()

please review (dunno if I also need sr=)

Comment 9

[J.J. Enser]

Attachment: patch to mozilla/build/mac/build_scripts/MozillaBuildList.pm

Comment 10

[Simon Fraser [no longer active]]

sr=sfraser on the patch.

Comment 11

[J.J. Enser]

patch checked in.

Comment 12

[Doron Rosenberg (IBM)]

can anyone verify? i don't have a mac build

Comment 13

[J.J. Enser]

I cannot "officially" verify this bug since I'm the one who fixed it ;-)
but fyi, I checked the release build mac and everything went fine over there (5 
files get porperly installed under defaults/profile). I haven't run the 
installer, but I see the files inside of deflenus.xpi so we should be ok.

Doron, you are "QA assigned" for this bug, so you should precisely verify it. If 
you don't have a mac, then let me know and I'll change the assignee.

Comment 14

[Conrad Carlen (not reading bugmail)]

Having aliases in the defaults dir (at least profiles) causes a problem. When a
new profile is made, files are copied from the defaults dir to the new profile
dir. If an alias is copied instead of the original file, when mozilla writes to
that file in the profile dir, it is modifying the original file which was
checked out from the tree. It causes the file to show up as modified as far as
CVS goes. Also, if multiple profiles were made using these aliases, each profile
is reading and writing the same file. The old build scripts copied actual files
and didn't have this problem.

Comment 15

[J.J. Enser]

Understood.
Note: this affects developers builds only since Release builds do not include any 
alias (they are all resolved during the packaging).

However, copying the actual files into defaults instead of making aliases is a 
trivial change.
Patch to MozillaBuildList.pm will follow.

Comment 16

[J.J. Enser]

Attachment: patch #2 to MozillaBuildList.pm (file copy instead of aliases)

Comment 17

[Conrad Carlen (not reading bugmail)]

Thanks. Might we have the same problem with wallet defaults? I don't think the
files in prefs defaults ever get written to but I'm not sure about wallet.

Comment 18

[J.J. Enser]

who can give his/her input on wallet prefs? If this fits in this bug then I'd 
rather fix both at the same time, but if not, a separate bug can be created and 
all I need is a review for this one before I can check it in.

Comment 19

[Conrad Carlen (not reading bugmail)]

Steve is the one to ask about wallet prefs. Steve, doesn't wallet copy files
from the defaults dir and then modify them?

Comment 20

[Stephen P. Morse]

The files in defaults/wallet are tables that never change.  They are never 
copied to any other directories.  They are read in directly from the 
defaults directory each time the browser starts.

Comment 21

[Simon Fraser [no longer active]]

sr=sfraser on the last change

Comment 22

[Conrad Carlen (not reading bugmail)]

r=ccarlen
Mark the bug as fixed as soon as you checkin - I'm getting ready to commit a
(unrelated) change to this file as well

Comment 23

[J.J. Enser]

fix checked in