Closed Bug 432115 Opened 14 years ago Closed 14 years ago

Sidebars don't change color when window is inactive

Categories

(Firefox :: Theme, defect)

All
macOS
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 3

People

(Reporter: mstange, Assigned: mstange)

References

Details

(Keywords: polish)

Attachments

(1 file, 1 obsolete file)

From bug 431831 comment 17 by Stephen Horlander:
> Created an attachment (id=319265)
> Sidebars not changing colors
> 
> The sidebars on my build are only changing color at the top but not the rest.
> Works in the Library though.

It looks like I removed too much when cleaning up Kevin's patch...
I have attached the missing changes.
Attachment #319275 - Flags: review?(gavin.sharp)
Attachment #319275 - Flags: review?(gavin.sharp) → review+
Comment on attachment 319275 [details] [diff] [review]
Fix v1.0: Add the missing styles

a1.9=beltzner
Attachment #319275 - Flags: approval1.9+
Checking in browser/themes/pinstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/pinstripe/browser/browser.css,v  <--  browser.css
new revision: 1.153; previous revision: 1.152
done
Checking in browser/themes/pinstripe/browser/places/places.css;
/cvsroot/mozilla/browser/themes/pinstripe/browser/places/places.css,v  <--  places.css
new revision: 1.28; previous revision: 1.27
done
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3
Attached patch Padding fix (obsolete) — Splinter Review
Separate the rules so we can color the background without adding padding. Also removed the text-transform: uppercase since it doesn't work anyway(bug 101800).
Assignee: mstange → stephen
Status: RESOLVED → ASSIGNED
Resolution: FIXED → ---
Comment on attachment 319561 [details] [diff] [review]
Padding fix

Deleting is possible by a bugzilla admin, but I'll just obsolete and private it for now.
Attachment #319561 - Attachment is obsolete: true
Attachment #319561 - Attachment is private: true
Status: ASSIGNED → RESOLVED
Closed: 14 years ago14 years ago
Resolution: --- → FIXED
Assignee: stephen → mstange
Attachment #319561 - Attachment is private: false
Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008050619 Minefield/3.0pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.