432115 - Sidebars don't change color when window is inactive

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Markus Stange [:mstange]]

Attachment: Fix v1.0: Add the missing styles

From bug 431831 comment 17 by Stephen Horlander:
> Created an attachment (id=319265)
> Sidebars not changing colors
> 
> The sidebars on my build are only changing color at the top but not the rest.
> Works in the Library though.

It looks like I removed too much when cleaning up Kevin's patch...
I have attached the missing changes.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 319275 [details] [diff] [review]
Fix v1.0: Add the missing styles

a1.9=beltzner

Comment 2

[Johnathan Nightingale [:johnath]]

Checking in browser/themes/pinstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/pinstripe/browser/browser.css,v  <--  browser.css
new revision: 1.153; previous revision: 1.152
done
Checking in browser/themes/pinstripe/browser/places/places.css;
/cvsroot/mozilla/browser/themes/pinstripe/browser/places/places.css,v  <--  places.css
new revision: 1.28; previous revision: 1.27
done

Comment 3

[Stephen Horlander [:shorlander]]

Attachment: Padding fix

Separate the rules so we can color the background without adding padding. Also removed the text-transform: uppercase since it doesn't work anyway(bug 101800).

Comment 4

[Stephen Horlander [:shorlander]]

Oops, wrong bug... Anyway to delete that?

Comment 5

[Johnathan Nightingale [:johnath]]

Comment on attachment 319561 [details] [diff] [review]
Padding fix

Deleting is possible by a bugzilla admin, but I'll just obsolete and private it for now.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008050619 Minefield/3.0pre