432129 - Site icon on awesome bar should not have white center

Status: RESOLVED INVALID

(Firefox :: Theme, defect)

Description

[nightstalkerz]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008050406 Minefield/3.0pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008050406 Minefield/3.0pre

The awesome bar should not have a whitish gradient in the middle behind the site's actual icon as it looks out of place and not all sites use a square icon. This is more noticable on sites which are blue/green (certificate).

Reproducible: Always

Steps to Reproduce:
1. Look at the site icon background.
2. Go to https://www.paypal.com/ and loo at the icon.
Actual Results:  
Has gradient in background.

Expected Results:  
No background.

This may cause the user to think that sites with certificates has changed their icons.

Comment 1

[[:Cww]]

Do you have screenshots showing what you're seeing vs what you expect to see?  The white center in the paypal favicon is because the actual favicon isn't set up to be transparent there.

Comment 2

[nightstalkerz]

I know the Paypal icons isn't transparent but the area which hbox which holds the favicon in Firefox is.

http://img387.imageshack.us/my.php?image=faviconsiw3.png

The part behind the icons are the gradient I'm talking about. The nightlies 2 days ago were a solid colour.

Comment 3

[Kai Liu]

This change was made in 430767, and specifically, adding the white glow was intended to fix bug 430787 and bug 431461.  The behavior is intended.

In any case, the white glow sits atop the background, and it's not fully opaque, so it only lightens and will not turn the favicon area entirely white.  Also, on Windows and Linux, the glow is always present, in all states (the Mac themers decided to use it only for the SSL states).

Comment 4

[nightstalkerz]

(In reply to comment #3)
> This change was made in 430767, and specifically, adding the white glow was
> intended to fix bug 430787 and bug 431461.  The behavior is intended.

Has the opposite effect for me but thats justs me.