Closed Bug 432172 Opened 16 years ago Closed 2 years ago

A (trace malloc allocs) test results jumped 100k on 2008-05-01

Categories

(Core :: General, defect)

defect

Tracking

()

RESOLVED INCOMPLETE

People

(Reporter: reed, Unassigned)

References

()

Details

(Keywords: memory-footprint, regression)

Some patch on 2008-05-01 caused the trace malloc allocs test to jump 100k on all platforms. This seems to be another case of these tests that are still very important being overlooked. :(

Depending on when you look at the below graphs, you may need to increase the number of days shown in order to view the time before and after 2008-05-01.

http://build-graphs.mozilla.org/graph/query.cgi?tbox=fxdbug-linux-tbox.build.mozilla.org&testname=trace_malloc_allocs&units=count&autoscale=1&days=7&avg=1&

http://build-graphs.mozilla.org/graph/query.cgi?tbox=bm-xserve11.build.mozilla.org&testname=trace_malloc_allocs&units=count&autoscale=1&days=7&avg=1&

http://build-graphs.mozilla.org/graph/query.cgi?tbox=FXDBUG-WIN32-TB&testname=trace_malloc_allocs&units=count&autoscale=1&days=7&avg=1&
Flags: blocking1.9?
Same as bug 429794, we need to figure out what happened here. Reed: can you get us a bonsai link?
Flags: blocking1.9? → blocking1.9+
On Mac the window is just 15:00-15:10, and the build cycle where the problem first happened clearly pulled only nsBrowserGlue.js:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1209679800.1209680294.24411.gz&fulltext=1

The other possibility, though, is that this was the result of a change to http://www.mozilla.org/ .
Gavin, would bug 381365 have affected the tinderbox machine and caused them not to have any default bookmarks?  Would having default bookmarks really be expected to increase allocation counts by 100K?
(In reply to comment #4)
> Gavin, would bug 381365 have affected the tinderbox machine and caused them not
> to have any default bookmarks?

Yes. When I landed that patch it fixed the problem of most tinderbox profiles not having default bookmarks. (For example, we had to adjust some tests to compensate: attachment 318943 [details] [diff] [review].)
Decided not to block on this at the triage during the Firefox meeting. Seems to be related to importing bookmarks.html to the SQL DB, which will only hit users once.
Flags: blocking1.9+ → blocking1.9-
Bug 392193 reduces sql activity during bookmarks import, which might affect this bug.

https://bugzilla.mozilla.org/show_bug.cgi?id=392193#c16
Flags: wanted1.9.0.x?
Flags: wanted1.9.0.x? → wanted1.9.0.x+
QA Whiteboard: qa-not-actionable

In the process of migrating remaining bugs to the new severity system, the severity for this bug cannot be automatically determined. Please retriage this bug using the new severity system.

Severity: major → --

It seems unlikely that we're going to fix a 14 year old regression.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.