432255 - New "About One-Click Site ID" needs either one more or one fewer Passport Officer icons + explanations

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[Deb Richardson [:dria] (plz NEEDINFO)]

I was looking at the page on the new mozilla.com staging server here: https://www-firefox3.authstage.mozilla.com/en-US/firefox/security/identity/ and realized that there's either one too many or one too few Passport Officer icons.

If the page is strictly about the Site ID button, the red icon shouldn't be included on the page.  

If the page is describing all instances of the Passport Officer icon, then it should also include the new yellow icon.

Comment 1

[John Slater]

Jonathan, can you advise on this?

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

I meant to file this already (thanks, Deb!); see https://bugzilla.mozilla.org/show_bug.cgi?id=428948#c7

Comment 3

[Johnathan Nightingale [:johnath]]

Yeah, the yellow Passport Officer was a late addition to represent sites with invalid security certificates.  You can see it by going to any site that presents a broken cert, like: https://paypal.com/

I see three options:

1) Do nothing.  The site as-is is confusing to people who know that 5 states exist, but I don't think it would be confusing to a user who was just reading the web site to learn more about Firefox.  This inconsistency should obviously be fixed, but if fixing it before the site launches causes undue hardship and torment, I don't consider it stop-ship.

2) Remove the red Larry.  This is the next-to-least amount of change, since it only means removing text, not adding it, and might be doable at the HTML layer instead of l10n (by just hiding the section for red).  It could be justified too, since bug 428948 is not fixed yet, so there are only 3 states that actually show up in the "1-click site identity" UI, even if there are 5 colors of passport officer.

3) Add the yellow Larry.  This nets us the most complete page, and makes us future-proof against fixing bug 428948, but requires net-new strings be added to the page, which means translation churn.  If this is acceptable, I'd propose the text:

> The site tries to use invalid or unverified identity information.

So in terms of next steps, I think the call comes down to how much localization churn we can take.  If the answer is "some" I propose option 3.  If the answer is "None, but we can update later when you fix bug 428948, and we can hide this string in html" then I'd say we go with option 2.

Comment 4

[John Slater]

I'd be happy with option #3, but the main factor here is localization. Pascal, can you weigh in on which choice from Johnathan's comment is most palatable from that perspective?

Thanks!

Comment 5

[Pascal Chevrel:pascalc]

We should refrain from adding new content to any page if we want to release firefox on time, localizers ave already lots of stuff to do and this page has already been translated in 35 languages. We can hide or remove some stuff, but I would prefer any content addition to be done after the release, when we know that all locales are done with the current work.

Comment 6

[John Slater]

Given Pascal's input on comment #5, it sounds like we should go with option #2 presented by Johnathan in comment #3.

Steven, can you make that fix?

Comment 7

[Steven Garrity [:sgarrity]]

Red Larry has been removed in r12841. So long Red Larry!

Ok to mark this as FIXED?

Comment 8

[Johnathan Nightingale [:johnath]]

(In reply to comment #7)
> Red Larry has been removed in r12841. So long Red Larry!
> 
> Ok to mark this as FIXED?

Sounds good to me - I've commented in bug 428948 that once we resolve that bug, we should file a follow-up to update this page again, but that will definitely not happen before release.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Hotness; thanks again, Deb, for filing.

Verified FIXED