432298 - REFTEST UNEXPECTED PASS: file:///builds/slave/darwin/build/layout/reftests/svg/opacity-and-gradient-01.svg

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Benjamin Smedberg]

REFTEST UNEXPECTED PASS: file:///builds/slave/darwin/build/layout/reftests/svg/opacity-and-gradient-01.svg
On the mozilla-central mac unit-test box.

jwatt, I see a checkin from a while back about this:
http://bonsai.mozilla.org/cvslog.cgi?file=/mozilla/layout/reftests/svg/opacity-and-gradient-01.svg&rev=HEAD&mark=1.4
But mozilla-central appears to have this change correctly: http://hg.mozilla.org/mozilla-central/index.cgi/file/631ebb79c3f7/layout/reftests/svg/opacity-and-gradient-01.svg
Any other thoughts?

Comment 1

[Benjamin Smedberg]

Oh heh, related to bug 379610... can I just make it a passing testcase in all cases, then?

Comment 2

[Jonathan Watt [:jwatt]]

As far as I know, yes. This is a dupe of bug 420909 BTW. Dunno why someone hasn't closed that already.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

10.5 passes, and it's entirely possible that this was fixed in CoreGraphics in an update to 10.4 -- we don't/haven't updated the 10.4 machines, so I think they're running 10.4.8 (when the latest is 10.4.11).  Brian Ewins tested on his machines, but I bet they had the latest patch set.

So we should either disable this test, or get all the 10.4 machines upgraded and try again.

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: skip the test on cocoa

Let's just skip this entirely on cocoa for now.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 320589 [details] [diff] [review]
skip the test on cocoa

r=dbaron **if** you use random-if instead of skip-if.  skip should only be used for tests that crash.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(Also might want to cite this bug number in the comment in addition to the one that's already there.)

Comment 7

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Pushed with random-if and other bug # in comment.