Last Comment Bug 432303 - Replace PKIX_PL_Memcpy with memcpy
: Replace PKIX_PL_Memcpy with memcpy
PKIX optimization, bloat reduction
Product: NSS
Classification: Components
Component: Libraries (show other bugs)
: trunk
: All All
P3 normal (vote)
: 3.12.1
Assigned To: Alexei Volkov
Depends on:
  Show dependency treegraph
Reported: 2008-05-05 13:08 PDT by Nelson Bolyard (seldom reads bugmail)
Modified: 2008-06-12 10:24 PDT (History)
0 users
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

Patch v1 (6.53 KB, patch)
2008-06-11 16:43 PDT, Alexei Volkov
nelson: review+
Details | Diff | Splinter Review

Description User image Nelson Bolyard (seldom reads bugmail) 2008-05-05 13:08:32 PDT
PKIX_PL_Memcpy is brain dead. 
It offers no advantages over memcpy.  
Eliminate it and replace with memcpy calls.
Comment 1 User image Alexei Volkov 2008-06-11 16:43:06 PDT
Created attachment 324707 [details] [diff] [review]
Patch v1 

The patch replacing four calls of PKIX_PL_Memcpy with PORT_Memcpy. PKIX_PL_Memcpy also removed from pkix_pl_mem.c and pkix_pl_system.h.
Comment 2 User image Nelson Bolyard (seldom reads bugmail) 2008-06-11 18:22:47 PDT
Comment on attachment 324707 [details] [diff] [review]
Patch v1 

I don't know if this patch is complete, but it appears correct as far as it goes.
Comment 3 User image Alexei Volkov 2008-06-12 10:24:42 PDT
(In reply to comment #2)
> (From update of attachment 324707 [details] [diff] [review]
> I don't know if this patch is complete
There are no other occurrences of PKIX_PL_Memcpy function calls. The function was also completely removed from the sources. I think the patch is complete.

Patch is integrated. Closing the bug.  

Note You need to log in before you can comment on or make changes to this bug.