Closed
Bug 432303
Opened 18 years ago
Closed 18 years ago
Replace PKIX_PL_Memcpy with memcpy
Categories
(NSS :: Libraries, defect, P3)
NSS
Libraries
Tracking
(Not tracked)
RESOLVED
FIXED
3.12.1
People
(Reporter: nelson, Assigned: alvolkov.bgs)
Details
(Whiteboard: PKIX optimization, bloat reduction)
Attachments
(1 file)
|
6.53 KB,
patch
|
nelson
:
review+
|
Details | Diff | Splinter Review |
PKIX_PL_Memcpy is brain dead.
It offers no advantages over memcpy.
Eliminate it and replace with memcpy calls.
|
Reporter | |
Updated•18 years ago
|
Whiteboard: PKIX
|
|
Reporter | |
Updated•18 years ago
|
Priority: -- → P3
Whiteboard: PKIX → PKIX optimization, bloat reduction
|
|
Assignee | |
Comment 1•18 years ago
|
||
The patch replacing four calls of PKIX_PL_Memcpy with PORT_Memcpy. PKIX_PL_Memcpy also removed from pkix_pl_mem.c and pkix_pl_system.h.
Attachment #324707 -
Flags: review?(nelson)
|
|
Reporter | |
Comment 2•18 years ago
|
||
Comment on attachment 324707 [details] [diff] [review]
Patch v1
I don't know if this patch is complete, but it appears correct as far as it goes.
Attachment #324707 -
Flags: review?(nelson) → review+
|
|
Assignee | |
Comment 3•18 years ago
|
||
(In reply to comment #2)
> (From update of attachment 324707 [details] [diff] [review]
> I don't know if this patch is complete
There are no other occurrences of PKIX_PL_Memcpy function calls. The function was also completely removed from the sources. I think the patch is complete.
Patch is integrated. Closing the bug.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•