432311 - branch landing of bug#351476 (conversion of line endings in browser/EULA)

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

+++ This bug was initially created as a clone of Bug #351476 +++

Filed to track landing patch on branch.

Comment 1

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Land both attachment 307577 [details] [diff] [review] and also attachment 307578 [details] [diff] [review] . The attachment on this bug can be ignored, its just a placeholder for approval tracking.

Comment 2

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Attachment: ignore me, for approval tracking only

Comment 3

[Daniel Veditz [:dveditz]]

Not sure why this would "block", but approved for 1.8.1.15, a=dveditz for release-drivers.

Assigning to John so it's not "nobody". Please reassign as necessary.

Comment 4

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Need to find someone else to land this, as I dont have cvs commit privs yet.

Comment 5

[J. Paul Reed [:preed]]

Talked with joduinn on IRC this morning; I'm happy to land this, but I'm not 100% sure what all needs to land; I'm assuming:

"Convert EOL on README/LICENSE, do not edit inplace (Firefox 1.8 branch)" and "Convert EOL on README/LICENSE, do not edit inplace (Thunderbird 1.8 branch)"

The "[checked in] Remove unix2dos calls in post-mozilla-rel.pl" patch is trunk, but AFAIK, tinderbox isn't branched for the 1.8 branch, so that should be fine.

I'll land the two above bugs.

Comment 6

[J. Paul Reed [:preed]]

Landed: http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=&branchtype=match&dir=&file=&filetype=match&who=mozpreed%25sigkill.com&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2008-05-12+11%3A00&maxdate=2008-05-12+12%3A00&cvsroot=%2Fcvsroot

I'll let joduinn close.

Comment 7

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Cool, thanks Paul. 

(Also, just checked in bonsai that post-mozilla-rel.pl has not been branched for the 1.8 branch, so the one already-landed-on-trunk patch should be enough.)

Closing.