The default bug view has changed. See this FAQ.

branch landing of bug#351476 (conversion of line endings in browser/EULA)

RESOLVED FIXED

Status

()

Core
Build Config
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: joduinn, Assigned: joduinn)

Tracking

({fixed1.8.1.15})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

+++ This bug was initially created as a clone of Bug #351476 +++

Filed to track landing patch on branch.
Flags: blocking1.8.1.15?
Land both attachment 307577 [details] [diff] [review] and also attachment 307578 [details] [diff] [review] . The attachment on this bug can be ignored, its just a placeholder for approval tracking.
Created attachment 319453 [details] [diff] [review]
ignore me, for approval tracking only
Attachment #319453 - Flags: approval1.8.1.15?
Not sure why this would "block", but approved for 1.8.1.15, a=dveditz for release-drivers.

Assigning to John so it's not "nobody". Please reassign as necessary.
Assignee: nobody → joduinn
Flags: blocking1.8.1.15?
Attachment #319453 - Flags: approval1.8.1.15? → approval1.8.1.15+
Need to find someone else to land this, as I dont have cvs commit privs yet.
Keywords: checkin-needed
Talked with joduinn on IRC this morning; I'm happy to land this, but I'm not 100% sure what all needs to land; I'm assuming:

"Convert EOL on README/LICENSE, do not edit inplace (Firefox 1.8 branch)" and "Convert EOL on README/LICENSE, do not edit inplace (Thunderbird 1.8 branch)"

The "[checked in] Remove unix2dos calls in post-mozilla-rel.pl" patch is trunk, but AFAIK, tinderbox isn't branched for the 1.8 branch, so that should be fine.

I'll land the two above bugs.
Landed: http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=&branchtype=match&dir=&file=&filetype=match&who=mozpreed%25sigkill.com&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2008-05-12+11%3A00&maxdate=2008-05-12+12%3A00&cvsroot=%2Fcvsroot

I'll let joduinn close.
Cool, thanks Paul. 

(Also, just checked in bonsai that post-mozilla-rel.pl has not been branched for the 1.8 branch, so the one already-landed-on-trunk patch should be enough.)

Closing.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Keywords: checkin-needed
Keywords: fixed1.8.1.15
You need to log in before you can comment on or make changes to this bug.