432321 - Need to add the browser.EULA.override pref to all Talos profiles

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P1)

Description

[:Gavin Sharp [email: [e-mail]]]

To avoid the EULA popping up on Linux once the patch in bug 431713 is landed, we need to add the "browser.EULA.override" pref to the talos profiles. It's a boolean pref and the value should be "true".

(At the moment, it's only needed for Linux, but it is conceivable that we will require it on other platforms at some point in the future, so it should be added everywhere.)

Comment 1

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

From discussion in irc:

1) we only need to make this change on the talos master. Each slave will download the new pref setting at the start of the next test cycle.

2) it does *not* require restarting each slave, and therefore does not require a tree closure.

Comment 2

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

robcee volunteered to nail this.

Comment 3

[Rob Campbell [:rc] (:robcee)]

... as hard as I can. Standby for breakage.

Comment 4

[Rob Campbell [:rc] (:robcee)]

Attachment: talos EULA pref

I think this is all of them in use on production.

Comment 5

[Rob Campbell [:rc] (:robcee)]

Attachment: talos EULA pref 2

with correct options applied.

Comment 6

[[e-mail] (:bhearsum)]

Comment on attachment 319615 [details] [diff] [review]
talos EULA pref

looks fine

Comment 7

[[e-mail] (:bhearsum)]

Comment on attachment 319617 [details] [diff] [review]
talos EULA pref 2

Even finer!

Comment 8

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 319617 [details] [diff] [review]
talos EULA pref 2

Checking in configs/fast.production.sample.config;
/cvsroot/mozilla/tools/buildbot-configs/testing/talos/perfmaster/configs/fast.production.sample.config,v  <--  fast.production.sample.config
new revision: 1.4; previous revision: 1.3
done
Checking in configs/jss.production.sample.config;
/cvsroot/mozilla/tools/buildbot-configs/testing/talos/perfmaster/configs/jss.production.sample.config,v  <--  jss.production.sample.config
new revision: 1.3; previous revision: 1.2
done
Checking in configs/production.sample.config;
/cvsroot/mozilla/tools/buildbot-configs/testing/talos/perfmaster/configs/production.sample.config,v  <--  production.sample.config
new revision: 1.6; previous revision: 1.5
done
Checking in configs/production.sample.config.nochrome;
/cvsroot/mozilla/tools/buildbot-configs/testing/talos/perfmaster/configs/production.sample.config.nochrome,v  <--  production.sample.config.nochrome
new revision: 1.3; previous revision: 1.2
done
Checking in configs/production.sample.config.nogfx;
/cvsroot/mozilla/tools/buildbot-configs/testing/talos/perfmaster/configs/production.sample.config.nogfx,v  <--  production.sample.config.nogfx
new revision: 1.6; previous revision: 1.5
done

Comment 9

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Thanks robcee!

Comment 10

[alice nodelman [:alice] [:anode]]

This needs to be set for talos try and talos stage as well.

Comment 11

[alice nodelman [:alice] [:anode]]

Removing blocking status since this is fixed for production machines.

Comment 12

[alice nodelman [:alice] [:anode]]

Attachment: add eula pref to talos stage and talos try

Comment 13

[alice nodelman [:alice] [:anode]]

Checking in perf-staging/configs/sample.config;
/cvsroot/mozilla/tools/buildbot-configs/testing/talos/perf-staging/configs/sample.config,v  <--  sample.config
new revision: 1.3; previous revision: 1.2
done
Checking in tryperfmaster/configs/sample.config;
/cvsroot/mozilla/tools/buildbot-configs/testing/talos/tryperfmaster/configs/sample.config,v  <--  sample.config
new revision: 1.3; previous revision: 1.2
done

Comment 14

[alice nodelman [:alice] [:anode]]

Attachment: change for the config file included in the talos directory

I think that this is the last of the config files that need updating.

Comment 15

[alice nodelman [:alice] [:anode]]

Checking in sample.config;
/cvsroot/mozilla/testing/performance/talos/sample.config,v  <--  sample.config
new revision: 1.15; previous revision: 1.14
done

Comment 16

[alice nodelman [:alice] [:anode]]

Also updated http://wiki.mozilla.org/StandaloneTalos.

That should cover all of the talos config files.

(Really need to get to work on bug 432883)