432323 - Trying to delete the "Smart Bookmarks" folder crashes Firefox [@ nsNavHistoryResult::OnItemChanged]

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008050209 Minefield/3.0pre ID:2008050209

Trying to delete a folder on the Bookmarks Toolbar crashes Firefox. Currently I cannot give clear STR because it is not reproducible at the moment.

Crash id: eb4983c5-1aeb-11dd-90ce-001cc4e2bf68

First 20 frames:
0  	XUL  	nsNavHistoryResult::OnItemChanged  	 mozilla/toolkit/components/places/src/nsNavHistoryResult.cpp:4117
1 	XUL 	nsNavBookmarks::OnItemAnnotationRemoved 	mozilla/toolkit/components/places/src/nsNavBookmarks.cpp:2771
2 	XUL 	nsAnnotationService::RemoveItemAnnotations 	mozilla/toolkit/components/places/src/nsAnnotationService.cpp:1574
3 	XUL 	nsNavBookmarks::RemoveItem 	mozilla/toolkit/components/places/src/nsNavBookmarks.cpp:1027
4 	XUL 	NS_InvokeByIndex_P 	mozilla/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_unixish_x86.cpp:179
5 	XUL 	XPCWrappedNative::CallMethod 	mozilla/js/src/xpconnect/src/xpcwrappednative.cpp:2369
6 	XUL 	XPC_WN_CallMethod 	mozilla/js/src/xpconnect/src/xpcwrappednativejsops.cpp:1473
7 	libmozjs.dylib 	js_Invoke 	mozilla/js/src/jsinvoke.c:1296
8 	libmozjs.dylib 	js_Interpret 	mozilla/js/src/jsinterp.c:4851
9 	libmozjs.dylib 	js_Invoke 	mozilla/js/src/jsinvoke.c:1312
10 	XUL 	nsXPCWrappedJSClass::CallMethod 	mozilla/js/src/xpconnect/src/xpcwrappedjsclass.cpp:1523
11 	XUL 	nsXPCWrappedJS::CallMethod 	mozilla/js/src/xpconnect/src/xpcwrappedjs.cpp:559
12 	XUL 	PrepareAndDispatch 	mozilla/xpcom/reflect/xptcall/src/md/unix/xptcstubs_unixish_x86.cpp:93
13 	XUL 	nsXPTCStubBase::Stub3 	mozilla/xpcom/reflect/xptcall/src/md/unix/xptcstubs_unixish_x86.cpp:1
14 	XUL 	NS_InvokeByIndex_P 	mozilla/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_unixish_x86.cpp:179
15 	XUL 	XPCWrappedNative::CallMethod 	mozilla/js/src/xpconnect/src/xpcwrappednative.cpp:2369
16 	XUL 	XPC_WN_CallMethod 	mozilla/js/src/xpconnect/src/xpcwrappednativejsops.cpp:1473
17 	libmozjs.dylib 	js_Invoke 	mozilla/js/src/jsinvoke.c:1296
18 	libmozjs.dylib 	js_Interpret 	mozilla/js/src/jsinterp.c:4851
19 	libmozjs.dylib 	js_Invoke 	mozilla/js/src/jsinvoke.c:1312
20 	XUL 	nsXPCWrappedJSClass::CallMethod 	mozilla/js/src/xpconnect/src/xpcwrappedjsclass.cpp:1523

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

This is responsible for a single crash in the 2008050209 build - maybe it has to do with the fact that you were deleting that depricated folder? If so, this doesn't block, though I'm sure it might be annoying to some of our early beta testers.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Yeah, I tried to delete the "Smart Bookmarks" folder. After the restart the folder was still existent. Doing the deletion again doesn't crash the browser. So no idea if this is really happening due to the deprecated folder.

Comment 3

[Dietrich Ayala (:dietrich)]

(In reply to comment #2)
> Yeah, I tried to delete the "Smart Bookmarks" folder. After the restart the
> folder was still existent.

Is this reliably reproduceable? Can you provide a places.sqlite that exhibits the behavior?

> Doing the deletion again doesn't crash the browser.
> So no idea if this is really happening due to the deprecated folder.
> 

Regardless of deprecation, it was just a regular folder, with some smart bookmarks in it. At that point, I think it's creation was managed by a pref, so it didn't even have any special annotations.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Crashes with this stack are still reported against Firefox 3.0.3. There are about 57 within the last month:

http://crash-stats.mozilla.com/report/list?product=Firefox&query_search=signature&query_type=contains&query=nsNavHistoryResult%3A%3AOnItemChanged&date=&range_value=1&range_unit=months&do_query=1&signature=nsNavHistoryResult%3A%3AOnItemChanged(long%20long%2C%20nsACString_internal%20const%26%2C%20int%2C%20nsACString_internal%20const%26)

Two available comments:

* Tried the google bookmark this time and yup crashed again. What is it with FF3 and bookmarks?

* a folder called "Bookmarks Folder" appeared in my bookmark bar; I opened "Organize Bookmarks" selected "Bookmarks Folder" in my bookmarks bar, pressed delete, and FireFox disappeared (crashed)

Comment 5

[Marco Bonardo [:mak]]

imo this was the same as bug 487040, and the crash was due to us trying to notify a cycle collected result.
Unless you still see reports for this crash i'd suggest to mark this as WFM.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

There are still crashes on 1.9.0 with Firefox 3.0.10 reported:

http://crash-stats.mozilla.com/query/query?do_query=1&product=Firefox&version=Firefox%3A3.0.10&version=Firefox%3A3.0.10pre&version=Firefox%3A3.0.11pre&date=&range_value=1&range_unit=weeks&query_search=signature&query_type=startswith&query=nsNavHistoryResult%3A%3AOnItemChanged

Comment 7

[Marco Bonardo [:mak]]

yes, that has been fixed in 3.5, so what we are interested into is finding any report with 3.5. I guess we can wait a month after 3.5 has been released and then if no reports are present, close this.

Comment 8

[Jesse Ruderman]

http://crash-stats.mozilla.com/report/list?query_search=signature&query_type=contains&query=nsNavHistoryResult&date=&range_value=1&range_unit=weeks&do_query=1&signature=nsNavHistoryResult%3A%3AOnItemChanged%28long%20long%2C%20nsACString_internal%20const%26%2C%20int%2C%20nsACString_internal%20const%26%29

All nsNavHistoryResult::OnItemChanged crashes were 3.0.x.  (Curiously, all were Mac.)  So pretty safe to assume WFM on 3.5 and mozilla-central.

Comment 9

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv