Closed Bug 432366 Opened 15 years ago Closed 14 years ago

Paste of bookmark on "Bookmarks Menu" in sidebar causes "Recently Bookmarked" folder to expand


(Firefox :: Bookmarks & History, defect, P2)




Firefox 3.1a1


(Reporter: abillings, Assigned: asaf)



(1 file)

If a user copies a bookmark via context menu or keyboard in the bookmarks sidebar and then pastes on the "Bookmarks Menu" folder, the "Recently Bookmarks" folder will expand open when closed.

This was found in build Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008050404 Minefield/3.0pre.

Steps to Reproduce
1. Bookmark a page into the "Bookmarks Menu" folder.
2. Open the Bookmarks Sidebar (make sure the "Recently Bookmarked" folder is collapsed).
3. Right click on the bookmark just added and choose copy.
4. Right click on the "Bookmarks Menu" folder and choose paste.

Result: Bookmark is pasted and "Recently Bookmarked" folder expands.

I moved the "Recently Bookmarked" folder around (to see if it was just that the first folder opens) and, regardless of position, the "Recently Bookmarked" folder will be expanded to show its contents when the bookmark is pasted in.
wfm on windows, still valid on mac?
I can reproduce this. This happens because the paste-command code tries to select the pasted node (per its itemId), and finds it under "Recently Bookmarked" query before it reaches it under the bookmarks menu folder itself. I don't think this, or any other select-post-command scenario  should recourse into folders at all.
Attached patch patchSplinter Review
Assignee: nobody → mano
Attachment #328213 - Flags: review?(dietrich)
Priority: -- → P2
Target Milestone: --- → Firefox 3.1a1
Comment on attachment 328213 [details] [diff] [review]

Attachment #328213 - Flags: review?(dietrich) → review+
changeset e6ac4c25521f.
Closed: 14 years ago
Resolution: --- → FIXED
I noticed this bug while running BFTs against 3.0.6. I can verify that it works now with:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090117 Shiretoko/3.1b3pre Ubiquity/0.1.4 ID:20090117020415

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090117 Shiretoko/3.1b3pre (.NET CLR 3.5.30729) Ubiquity/0.1.5 ID:20090117035052
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.